Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not get stuck due to adaptive capping #749

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Do not get stuck due to adaptive capping #749

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
668a842
Do not get stuck due to adaptive capping
filipbartek Aug 4, 2021
dceed6c
Intensification: Discard capped challenger early
filipbartek Aug 13, 2021
0091ad8
Merge remote-tracking branch 'automl/development' into issue/748
filipbartek Sep 13, 2021
72e6fb0
Remove an unnecessary statement
filipbartek Sep 13, 2021
215e3b6
Update the documentation of the challenger discard process
filipbartek Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions smac/intensification/intensification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,9 @@ def get_next_run(self,

# If no more time, stage transition is a must
if not is_there_time_due_to_adaptive_cap:
# Since the challenger fails to outperform the incumbent due to adaptive capping,
# we discard all the forthcoming runs.
self.to_run = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply setting self.to_run = [] should suffice,
'self.continue_challenger' will be modified anyway under Intensification._process_racer_results (line 422)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having tested this on an example that I attached to issue #748, I agree that setting self.to_run suffices.
I have simplified the PR accordingly.

self.stage = IntensifierStage.RUN_INCUMBENT
self.logger.debug(
"Stop challenger itensification due "
Expand Down