-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up workflow files, Adds PEP 561 compliance #802
Conversation
Codecov Report
@@ Coverage Diff @@
## development #802 +/- ##
===============================================
+ Coverage 87.10% 87.13% +0.03%
===============================================
Files 68 68
Lines 6227 6236 +9
===============================================
+ Hits 5424 5434 +10
+ Misses 803 802 -1
Continue to review full report at Codecov.
|
Looks good! |
I would remove that file as it doesn't really do anything but I wasn't sure, so I just deactivated it for now |
That file was there to run the commandline examples. It would be better to reactivate this behavior to ensure that these examples are working as expected. |
That's not what it's doing but isn't that covered with |
I also fixed the PEP 561 compliance check and then also added the compliance. This means a user using SMAC with |
No, |
That's on me. When we integrated the new docs, we couldn't get the tests working and decided to exclude it for now. But yeah, we will integrate them again in 1.1.2. |
This PR cleans up the github action workflow files to accomplish few things:
workflow_dispatch
on actions that might require it (can manually trigger them from github UI)push
andpull_request
and more strict.on: [push, pull_request]
example.yaml
workflow as it did nothing but install SMAC. (Also removed the parameterization of it)pytest.yaml
:Once I figure out how to make the tests work windows and macos, I will create a new PR and enable windows/mac testing.