Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust hyperband configuration distribution across brackets #980

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Adjust hyperband configuration distribution across brackets #980

merged 2 commits into from
Apr 25, 2023

Conversation

helegraf
Copy link
Contributor

Addresses issue #977 by choosing the original paper algorithm (not the example table) as the implementation for the bracket scaling. Thank you @AlexandreAbraham for reporting this on the (not maintained anymore) BOHB repository.

@helegraf helegraf self-assigned this Apr 18, 2023
@AlexandreAbraham
Copy link

Hey @helegraf,
Glad that my contribution could help! Thanks for translating this into proper code. Don't hesitate to ping me next time you're in Paris, I'll pay you a beer (or whatever you poison is). I'll also give a try to review your PR if I have some time.

@helegraf helegraf removed the request for review from timruhkopf April 25, 2023 12:33
alexandertornede
alexandertornede approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@alexandertornede alexandertornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helegraf
Copy link
Contributor Author

Thanks for reviewing! And @AlexandreAbraham I'll hold you to that ;)

@helegraf helegraf merged commit 93b67d5 into development Apr 25, 2023
@helegraf helegraf deleted the fix/hyperband_bracket_scaling branch April 25, 2023 14:18
@helegraf helegraf mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-segel sarah-segel sarah-segel approved these changes

@alexandertornede alexandertornede alexandertornede approved these changes

Assignees

@helegraf helegraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@helegraf @AlexandreAbraham @sarah-segel @alexandertornede