-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement menu and functionality to discard tabs, fixes #11. #33
base: master
Are you sure you want to change the base?
Conversation
Any feedback on this @autonome? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the PR, and thanks for poking me about it!
I've left a few comments on the PR, mostly minor.
One question is about the use of "retire". I'm not sure it's the right word here. I've been using asleep/awake, so that there's no worry of tabs actually going away. Even those aren't absolutely consistent with "dormant", but I think they're closer?
// Start everything. Or cancel what's going on and restart. | ||
async function init() { | ||
// Load (or reload) config from storage | ||
let oldConfig = config; | ||
config = await loadConfig(); | ||
addMenu(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: add a space between this and the config loading bit, with a comment explaining what's happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
_locales/en/messages.json
Outdated
"description": "Menu item to retire all selected / highlighted tabs." | ||
}, | ||
"menuDiscardLeft": { | ||
"message": "Retire tabs to the &left", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm not familiar enough with localizing entities - what happens with "&left"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That l should be underlined and should be an access key.
Have to test this myself on windows as mac does not support this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought a bit more about it and would like to use "put so sleep" throughout according to https://www.merriam-webster.com/dictionary/put%20to%20sleep bullet 3. Maybe it is time for more consistency and use Dormany only as the extension name and otherwise stay with (put to) sleep and awake or wake up? |
New version of the code pushed |
f42645c
to
1bc7794
Compare
Merry Christmas!
This pull request adds a tab menu for Dormancy to discard selected, left, right or other tabs.
If anything comes up during review please do not hesitate to tell me about it.