Upgrade sdk to gemini-3g-2024-jan-08 #237
Conversation
ParthDesai
force-pushed
the
upgrade-to-jan-08
branch
from
b7ee017 to
df3a162
Compare
|
Update: @nazar-pc @jfrank-summit Fixed now. Mac CI jobs are failing with the error: perl: warning: Falling back to the standard locale ("C").
configure.ac:44: installing './config/compile'
configure.ac:40: installing './config/missing'
contrib/misc/Makefile.am: installing './config/depcomp'
autoreconf: './config/config.sub' is updated
autoreconf: './config/config.guess' is updated
autoreconf: './config/install-sh' is updated
autoreconf: Leaving directory '.'
configure: WARNING: "-fvisibility=hidden" has been added to the hwloc CFLAGS
make[1]: *** read jobs pipe: Resource temporarily unavailable. Stop.
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1 |
ParthDesai
force-pushed
the
upgrade-to-jan-08
branch
3 times, most recently
from
1080df8 to
2764044
Compare
ParthDesai
force-pushed
the
upgrade-to-jan-08
branch
from
2764044 to
2c57c53
Compare
Cargo.toml
Outdated
| "sdk-farmer/numa", | ||
| "sdk-dsn/numa", | ||
| "sdk-utils/numa", | ||
| "sdk-node/numa", | ||
| "sdk-substrate/numa" |
There was a problem hiding this comment.
Why would so many features need to be aware of NUMA support? subspace-farmer is the only crate with NUMA awareness, is it really a dependency of every single of those crate AND makes a difference there?
There was a problem hiding this comment.
@nazar-pc Yes. Almost every package either uses something from subspace farmer (for example, sdk-utils uses NodeClient and sdk-dsn uses PieceCache) and/or uses the sdk-utils or sdk-dsn package.
Initial plan to have only sdk-farmer have numa feature, but there is enough inter-dependency that I need to add it everywhere.
There was a problem hiding this comment.
Hmm. Maybe I can mark default-features=false and try to simplify this.
There was a problem hiding this comment.
Maybe I can mark default-features=false and try to simplify this
Yes, please do
There was a problem hiding this comment.
Simplified. Only sdk-farmer has numa dependency now.
Description
This PR updates sdk to
gemini-3g-2023-jan-08snapshot.Notable changes: