Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune the transaction from pool instead of removing it as invalid #1480

Merged
merged 1 commit into from
May 31, 2023
Merged

Prune the transaction from pool instead of removing it as invalid #1480

merged 1 commit into from
May 31, 2023

Conversation

liuchengxu
Copy link
Contributor

All the existing usages of remove_tx_from_tx_pool are to remove a ready transaction from the pool if I'm not wrong, this PR refactors it into prune_tx_from_pool, removing such transactions using prune_known instead of marking them as invalid and causing the same transaction banned.

Close #1399

Code contributor checklist:

@liuchengxu liuchengxu requested a review from NingLin-P May 31, 2023 03:42
NingLin-P
NingLin-P approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liuchengxu liuchengxu merged commit 4f3ed1a into main May 31, 2023
@liuchengxu liuchengxu deleted the prune-tx-instead-of-remove-invalid branch May 31, 2023 16:49
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Jun 22, 2023
@i1i1
Import autonomys/subspace#1476,autonomys/subspace#1480,autonomys/subs…
bc12635 
…pace#1489,autonomys/subspace#1489,autonomys/subspace#1477,autonomys/subspace#1481,autonomys/subspace#1496,autonomys/subspace#1497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NingLin-P NingLin-P NingLin-P approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thread 'tests::duplicated_and_stale_bundle_should_be_rejected' panicked at 'assertion failed: (left == right)
2 participants
@liuchengxu @NingLin-P