subspace-core-primitives refactoring
#3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
NingLin-P,
rg3l3dr and
shamil-gadelshin
as code owners
nazar-pc
changed the title
subspace-core-primitives refactoring
shamil-gadelshin
previously approved these changes
Oct 2, 2024
nazar-pc
force-pushed
the
subspace-core-primitives-refactoring
branch
from
12a1c91
to
d7c664b
Compare
|
I didn't check clippy with |
nazar-pc
force-pushed
the
subspace-core-primitives-refactoring
branch
from
d7c664b
to
0395e9a
Compare
|
Missed tests 🙈 |
|
And added one more small thing on top |
|
Last attempt? |
1 task
teor2345
approved these changes
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years a lot of stuff ended up in somewhat arbitrary places, this simply moves stuff around to have a more logical hierarchy and removes re-exports so it is clear where things are coming from.
Code contributor checklist: