Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pallet-Messenger-3 #852

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Pallet-Messenger-3 #852

merged 9 commits into from
Oct 10, 2022

Conversation

vedhavyas
Copy link
Member

This PR brings the following changes.

  • Define Endpoint, traits for Endpoint to send and receive messages
  • Add Endpoint message passing between domains with open channel.

Code contributor checklist:

liuchengxu
liuchengxu reviewed Oct 10, 2022
View reviewed changes
crates/pallet-messenger/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-messenger/src/lib.rs Outdated Show resolved Hide resolved
crates/pallet-messenger/src/lib.rs Show resolved Hide resolved
liuchengxu
liuchengxu approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@liuchengxu liuchengxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@vedhavyas vedhavyas enabled auto-merge October 10, 2022 09:33
@vedhavyas vedhavyas merged commit d11425f into main Oct 10, 2022
@vedhavyas vedhavyas deleted the pallet-messenger-3 branch October 10, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuchengxu liuchengxu liuchengxu approved these changes

@nazar-pc nazar-pc Awaiting requested review from nazar-pc

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedhavyas @liuchengxu