Merge pull request #530 from tier4/sync-awf-latest

chore: sync awf-latest

.clang-tidy

@@ -1,4 +1,3 @@
----
 Checks: "
   -*,
   boost-use-to-string,
@@ -138,6 +137,7 @@ Checks: "
   readability-delete-null-pointer,
   readability-else-after-return,
   readability-function-cognitive-complexity,
+  readability-identifier-naming,
   readability-inconsistent-declaration-parameter-name,
   readability-isolate-declaration,
   readability-make-member-function-const,
@@ -199,7 +199,7 @@ WarningsAsErrors: "
   readability-misplaced-array-index,
   readability-string-compare"
 
-HeaderFilterRegex: "^(?!\/usr)(?!\/opt)"
+HeaderFilterRegex: ^(?!\/usr)(?!\/opt)
 
 AnalyzeTemporaryDtors: false
 
@@ -229,7 +229,7 @@ CheckOptions:
   - key: bugprone-assert-side-effect.CheckFunctionCalls
     value: "0"
   - key: bugprone-dangling-handle.HandleClasses
-    value: "std::basic_string_view;std::experimental::basic_string_view"
+    value: std::basic_string_view;std::experimental::basic_string_view
   - key: bugprone-dynamic-static-initializers.HeaderFileExtensions
     value: ",h,hh,hpp,hxx"
   - key: bugprone-exception-escape.FunctionsThatShouldNotThrow
@@ -273,25 +273,25 @@ CheckOptions:
   - key: bugprone-unhandled-self-assignment.WarnOnlyIfThisHasSuspiciousField
     value: "1"
   - key: bugprone-unused-return-value.CheckedFunctions
-    value: "::std::async;::std::launder;::std::remove;::std::remove_if;::std::unique;::std::unique_ptr::release;::std::basic_string::empty;::std::vector::empty"
+    value: ::std::async;::std::launder;::std::remove;::std::remove_if;::std::unique;::std::unique_ptr::release;::std::basic_string::empty;::std::vector::empty
   - key: cert-dcl16-c.NewSuffixes
-    value: "L;LL;LU;LLU"
+    value: L;LL;LU;LLU
   - key: cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
     value: "0"
   - key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
     value: "1"
   - key: cppcoreguidelines-macro-usage.AllowedRegexp
-    value: "^DEBUG_*"
+    value: ^DEBUG_*
   - key: cppcoreguidelines-macro-usage.CheckCapsOnly
     value: "0"
   - key: cppcoreguidelines-macro-usage.IgnoreCommandLineMacros
     value: "1"
   - key: cppcoreguidelines-no-malloc.Allocations
-    value: "::malloc;::calloc"
+    value: ::malloc;::calloc
   - key: cppcoreguidelines-no-malloc.Deallocations
-    value: "::free"
+    value: ::free
   - key: cppcoreguidelines-no-malloc.Reallocations
-    value: "::realloc"
+    value: ::realloc
   - key: cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
     value: "1"
   - key: cppcoreguidelines-pro-type-member-init.IgnoreArrays
@@ -331,17 +331,17 @@ CheckOptions:
   - key: modernize-make-shared.IgnoreMacros
     value: "1"
   - key: modernize-make-shared.IncludeStyle
-    value: "google"
+    value: google
   - key: modernize-make-shared.MakeSmartPtrFunction
-    value: "std::make_shared"
+    value: std::make_shared
   - key: modernize-make-shared.MakeSmartPtrFunctionHeader
     value: memory
   - key: modernize-make-unique.IgnoreMacros
     value: "1"
   - key: modernize-make-unique.IncludeStyle
-    value: "google"
+    value: google
   - key: modernize-make-unique.MakeSmartPtrFunction
-    value: "std::make_unique"
+    value: std::make_unique
   - key: modernize-make-unique.MakeSmartPtrFunctionHeader
     value: memory
   - key: modernize-pass-by-value.IncludeStyle
@@ -363,13 +363,13 @@ CheckOptions:
   - key: modernize-use-default-member-init.UseAssignment
     value: "0"
   - key: modernize-use-emplace.ContainersWithPushBack
-    value: "::std::vector;::std::list;::std::deque"
+    value: ::std::vector;::std::list;::std::deque
   - key: modernize-use-emplace.SmartPointers
-    value: "::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr"
+    value: ::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr
   - key: modernize-use-emplace.TupleMakeFunctions
-    value: "::std::make_pair;::std::make_tuple"
+    value: ::std::make_pair;::std::make_tuple
   - key: modernize-use-emplace.TupleTypes
-    value: "::std::pair;::std::tuple"
+    value: ::std::pair;::std::tuple
   - key: modernize-use-equals-default.IgnoreMacros
     value: "1"
   - key: modernize-use-equals-delete.IgnoreMacros
@@ -395,7 +395,7 @@ CheckOptions:
   - key: modernize-use-using.IgnoreMacros
     value: "1"
   - key: performance-faster-string-find.StringLikeClasses
-    value: "std::basic_string"
+    value: std::basic_string
   - key: performance-for-range-copy.AllowedTypes
     value: ""
   - key: performance-for-range-copy.WarnOnAllAutoCopies
@@ -405,7 +405,7 @@ CheckOptions:
   - key: performance-inefficient-vector-operation.EnableProto
     value: "0"
   - key: performance-inefficient-vector-operation.VectorLikeClasses
-    value: "::std::vector"
+    value: ::std::vector
   - key: performance-move-const-arg.CheckTriviallyCopyableMove
     value: "1"
   - key: performance-move-constructor-init.IncludeStyle
@@ -417,24 +417,44 @@ CheckOptions:
   - key: performance-unnecessary-copy-initialization.AllowedTypes
     value: ""
   - key: performance-unnecessary-value-param.AllowedTypes
-    value: ".*Ptr"
+    value: .*Ptr;.*SharedFuture
   - key: performance-unnecessary-value-param.IncludeStyle
     value: google
   - key: portability-simd-intrinsics.Std
     value: ""
   - key: portability-simd-intrinsics.Suggest
     value: "0"
+  - key: readability-function-cognitive-complexity.IgnoreMacros
+    value: "1"
   - key: readability-else-after-return.WarnOnUnfixable
     value: "1"
+  - key: readability-identifier-naming.NamespaceCase
+    value: lower_case
+  - key: readability-identifier-naming.ClassCase
+    value: CamelCase
+  - key: readability-identifier-naming.PrivateMemberSuffix
+    value: _
+  - key: readability-identifier-naming.StructCase
+    value: CamelCase
+  - key: readability-identifier-naming.FunctionCase
+    value: lower_case
+  - key: readability-identifier-naming.VariableCase
+    value: lower_case
+  - key: readability-identifier-naming.GlobalConstantCase
+    value: lower_case
+  - key: readability-identifier-naming.GlobalConstantPrefix
+    value: g_
+  - key: readability-identifier-naming.ConstexprVariableCase
+    value: lower_case
   - key: readability-inconsistent-declaration-parameter-name.IgnoreMacros
     value: "1"
   - key: readability-inconsistent-declaration-parameter-name.Strict
     value: "0"
   - key: readability-redundant-smartptr-get.IgnoreMacros
     value: "1"
   - key: readability-redundant-string-init.StringNames
-    value: "::std::basic_string"
+    value: ::std::basic_string
   - key: readability-simplify-subscript-expr.Types
-    value: "::std::basic_string;::std::basic_string_view;::std::vector;::std::array"
+    value: ::std::basic_string;::std::basic_string_view;::std::vector;::std::array
   - key: readability-static-accessed-through-instance.NameSpecifierNestingThreshold
     value: "3"

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,56 +1,8 @@
-## PR Type
+**Note**: Confirm the [contribution guidelines](https://autowarefoundation.github.io/autoware-documentation/main/contributing/) before submitting a pull request.
 
-<!-- Select one and remove others. If an appropriate one is not listed, please write by yourself. -->
+Click the `Preview` tab and select a PR template:
 
-- New Feature
-- Improvement
-- Bug Fix
+- [Standard change](?expand=1&template=standard-change.md)
+- [Small change](?expand=1&template=small-change.md)
 
-## Related Links
-
-<!-- Please write related links to GitHub/Jira/Slack/etc. -->
-
-## Description
-
-<!-- Describe what this PR changes. -->
-
-## Review Procedure
-
-<!-- Explain how to review this PR. -->
-
-## Remarks
-
-<!-- Write remarks as you like if you need them. -->
-
-## Pre-Review Checklist for the PR Author
-
-**PR Author should check the checkboxes below when creating the PR.**
-
-- [ ] Code follows [coding guidelines][coding-guidelines]
-- [ ] Assign PR to reviewer
-
-## Checklist for the PR Reviewer
-
-**Reviewers should check the checkboxes below before approval.**
-
-- [ ] Commits are properly organized and messages are according to the guideline
-- [ ] Code follows [coding guidelines][coding-guidelines]
-- [ ] (Optional) Unit tests have been written for new behavior
-- [ ] PR title describes the changes
-
-## Post-Review Checklist for the PR Author
-
-**PR Author should check the checkboxes below before merging.**
-
-- [ ] All open points are addressed and tracked via issues or tickets
-- [ ] Write [release notes][release-notes]
-- [ ] (When added something to `.repos`) Check if proper access rights are set
-
-## CI Checks
-
-- **vcs import**: Required to pass before the merge.
-- **Check spelling**: NOT required to pass before the merge. It is up to the reviewer(s). See [here][spell-check-dict] if you want to add some words to the spell check dictionary.
-
-[coding-guidelines]: https://tier4.atlassian.net/wiki/spaces/AIP/pages/1194394777/T4
-[release-notes]: https://tier4.atlassian.net/wiki/spaces/AIP/pages/563774416
-[spell-check-dict]: https://github.com/tier4/autoware-spell-check-dict#how-to-contribute
+**Do NOT send a PR with this description.**

.github/PULL_REQUEST_TEMPLATE/small-change.md

@@ -0,0 +1,27 @@
+## Description
+
+<!-- Write a brief description of this PR. -->
+
+## Pre-review checklist for the PR author
+
+The PR author **must** check the checkboxes below when creating the PR.
+
+- [ ] I've confirmed the [contribution guidelines].
+- [ ] The PR follows the [pull request guidelines].
+
+## In-review checklist for the PR reviewers
+
+The PR reviewers **must** check the checkboxes below before approval.
+
+- [ ] The PR follows the [pull request guidelines].
+
+## Post-review checklist for the PR author
+
+The PR author **must** check the checkboxes below before merging.
+
+- [ ] There are no open discussions or they are tracked via tickets.
+
+After all checkboxes are checked, anyone who has write access can merge the PR.
+
+[contribution guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/
+[pull request guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/

.github/PULL_REQUEST_TEMPLATE/standard-change.md

@@ -0,0 +1,42 @@
+## Description
+
+<!-- Write a brief description of this PR. -->
+
+## Related links
+
+<!-- Write the links related to this PR. -->
+
+## Tests performed
+
+<!-- Describe how you have tested this PR. -->
+
+## Notes for reviewers
+
+<!-- Write additional information if necessary. It should be written if there are related PRs that should be merged at the same time. -->
+
+## Pre-review checklist for the PR author
+
+The PR author **must** check the checkboxes below when creating the PR.
+
+- [ ] I've confirmed the [contribution guidelines].
+- [ ] The PR follows the [pull request guidelines].
+
+## In-review checklist for the PR reviewers
+
+The PR reviewers **must** check the checkboxes below before approval.
+
+- [ ] The PR follows the [pull request guidelines].
+- [ ] The PR has been properly tested.
+- [ ] The PR has been reviewed by the code owners.
+
+## Post-review checklist for the PR author
+
+The PR author **must** check the checkboxes below before merging.
+
+- [ ] There are no open discussions or they are tracked via tickets.
+- [ ] The PR is ready for merge.
+
+After all checkboxes are checked, anyone who has write access can merge the PR.
+
+[contribution guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/
+[pull request guidelines]: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/

.github/sync-files.yaml

@@ -1,7 +1,11 @@
 - repository: autowarefoundation/autoware
   files:
     # General
+    - source: .github/PULL_REQUEST_TEMPLATE.md
+    - source: .github/PULL_REQUEST_TEMPLATE/small-change.md
+    - source: .github/PULL_REQUEST_TEMPLATE/standard-change.md
     - source: .github/dependabot.yaml
+    - source: .github/workflows/cancel-previous-workflows.yaml
     - source: .github/workflows/github-release.yaml
     - source: .github/workflows/pre-commit.yaml
     - source: .github/workflows/pre-commit-ansible.yaml
@@ -10,6 +14,7 @@
     - source: .github/workflows/spell-check-differential.yaml
     - source: .github/workflows/sync-files.yaml
     - source: .clang-format
+    - source: .clang-tidy
     - source: .markdownlint.yaml
     - source: .pre-commit-config.yaml
     - source: .pre-commit-config-ansible.yaml

.github/workflows/build-humble.yaml

@@ -2,7 +2,7 @@ name: build-humble
 
 on:
   schedule:
-    - cron: 0 0 * * 0
+    - cron: 0 12 * * *
   workflow_dispatch:
 
 jobs:

.github/workflows/build-main.yaml

@@ -2,7 +2,7 @@ name: build-main
 
 on:
   schedule:
-    - cron: 0 0 * * 0
+    - cron: 0 12 * * *
   workflow_dispatch:
 
 jobs:

.github/workflows/cancel-previous-workflows.yaml

@@ -0,0 +1,14 @@
+name: cancel-previous-workflows
+
+on:
+  pull_request_target:
+
+jobs:
+  cancel-previous-workflows:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Cancel previous runs
+        uses: styfle/cancel-workflow-action@0.10.0
+        with:
+          workflow_id: all
+          all_but_latest: true

.github/workflows/update-ansible-galaxy-requirements.yaml

@@ -30,8 +30,12 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Update clang-format version
+      - name: Update Autoware version
+        id: update-autoware-version
         run: |
+          current_hash=$(yq '.collections[] | select(.name == "https://github.com/autowarefoundation/autoware.git#/ansible").version' ansible-galaxy-requirements.yaml)
+          echo ::set-output name=current-version::"$current_hash"
+
           sd -f ms \
             '(https://github.com/autowarefoundation/autoware.git#/ansible.*version): \w+' \
             '$1: ${{ steps.get-latest-autoware-version.outputs.version }}' \
@@ -46,7 +50,9 @@ jobs:
           branch: update-ansible-galaxy-requirements
           title: "chore: update ansible-galaxy-requirements.yaml"
           commit-message: "chore: update ansible-galaxy-requirements.yaml"
-          body: https://github.com/autowarefoundation/autoware/commit/${{ steps.get-latest-autoware-version.outputs.version }}
+          body: |
+            https://github.com/autowarefoundation/autoware/commits/main
+            https://github.com/autowarefoundation/autoware/compare/${{ steps.update-autoware-version.outputs.current-version }}..${{ steps.get-latest-autoware-version.outputs.version }}
           labels: |
             bot
             dependencies

.yamllint.yaml

@@ -1,7 +1,6 @@
 extends: default
 
 ignore: |
-  .clang-tidy
   *.param.yaml
 
 rules:

ansible-galaxy-requirements.yaml

@@ -4,4 +4,4 @@ collections:
 
   - name: https://github.com/autowarefoundation/autoware.git#/ansible
     type: git
-    version: b1e2f6ef5982ccbe9434bff49397b2783713cb98
+    version: 2a3eaf561514e4ddfc35bfcc30fc28c881ae626d