feat(map_tf_generator)!: launching planning_simulator without pointcloud map #1216

shmpwk · 2022-07-02T05:58:12Z

Description

Adress #1203.
Note that this PR will change viewer frame of Rviz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-07-02T06:15:05Z

Codecov Report

Merging #1216 (3795ab3) into main (4542c52) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1216      +/-   ##
========================================
- Coverage   9.58%   9.57%   -0.02%     
========================================
  Files       1045    1047       +2     
  Lines      66635   66730      +95     
  Branches   15283   15283              
========================================
  Hits        6389    6389              
- Misses     54438   54533      +95     
  Partials    5808    5808

Flag	Coverage Δ		*Carryforward flag
differential	`1.89% <0.00%> (?)`
total	`9.58% <ø> (ø)`		Carriedforward from 4542c52

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...map_tf_generator/src/pcd_map_tf_generator_node.cpp	`0.00% <0.00%> (ø)`
..._tf_generator/src/vector_map_tf_generator_node.cpp	`0.00% <0.00%> (ø)`
...onitor/include/ad_service_state_monitor/config.hpp	`0.00% <0.00%> (ø)`
...include/ad_service_state_monitor/state_machine.hpp	`0.00% <0.00%> (ø)`
...rc/ad_service_state_monitor_node/state_machine.cpp	`0.00% <0.00%> (ø)`
...ate_monitor_node/ad_service_state_monitor_node.cpp	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4542c52...3795ab3. Read the comment docs.

yukkysaito

LGTM

kenji-miyake

Generally LGTM. I added some small coments.

system/ad_service_state_monitor/config/ad_service_state_monitor.planning_simulation.param.yaml

map/map_tf_generator/Readme.md

map/map_tf_generator/src/vector_map_tf_generator_node.cpp

shmpwk · 2022-07-05T11:45:33Z

@kenji-miyake thank you for your checking! I finished fixing.

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

kenji-miyake

Great work! Thank you. 🙏

…oud map (tier4#1216) * feat(map_tf_generator): add vector map tf generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix(ad_service_state_monitor): rm unused cofig param Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: change launching vector_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * docs: update readme Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * refactor: rename map_tf_generator -> pcd_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix: build error Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/src/vector_map_tf_generator_node.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

…oud map (autowarefoundation#1216) * feat(map_tf_generator): add vector map tf generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix(ad_service_state_monitor): rm unused cofig param Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: change launching vector_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * docs: update readme Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * refactor: rename map_tf_generator -> pcd_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix: build error Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/src/vector_map_tf_generator_node.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

…oud map (tier4#1216) * feat(map_tf_generator): add vector map tf generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix(ad_service_state_monitor): rm unused cofig param Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: change launching vector_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * docs: update readme Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * refactor: rename map_tf_generator -> pcd_map_tf_generator Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * fix: build error Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/src/vector_map_tf_generator_node.cpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update map/map_tf_generator/Readme.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

shmpwk added type:new-feature New functionalities or additions, feature requests. component:map Map creation, storage, and loading. (auto-assigned) labels Jul 2, 2022

shmpwk mentioned this pull request Jul 2, 2022

Launching planning_simulator without pointcloud map (only with vector map) #1203

Closed

9 tasks

shmpwk force-pushed the feat/vector_map_tf_generator branch 3 times, most recently from f17b121 to 7b16382 Compare July 2, 2022 09:27

taikitanaka3 changed the title ~~feat(map_tf_generator!): launching autoware without pointcloud map~~ feat(map_tf_generator)!: launching autoware without pointcloud map Jul 3, 2022

shmpwk changed the title ~~feat(map_tf_generator)!: launching autoware without pointcloud map~~ feat(map_tf_generator)!: launching planning_simulator without pointcloud map Jul 3, 2022

shmpwk marked this pull request as ready for review July 3, 2022 23:46

shmpwk requested review from yukkysaito, kenji-miyake and mitsudome-r July 5, 2022 00:52

yukkysaito approved these changes Jul 5, 2022

View reviewed changes

kenji-miyake reviewed Jul 5, 2022

View reviewed changes

shmpwk and others added 10 commits July 5, 2022 20:46

feat(map_tf_generator): add vector map tf generator

8a94809

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

fix(ad_service_state_monitor): rm unused cofig param

007419e

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

chore: change launching vector_map_tf_generator

2b18e14

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

docs: update readme

96b8bac

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

refactor: rename map_tf_generator -> pcd_map_tf_generator

379348a

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

fix: build error

9e41e7b

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

Update map/map_tf_generator/Readme.md

a1a3836

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Update map/map_tf_generator/src/vector_map_tf_generator_node.cpp

4c77d3e

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Update map/map_tf_generator/Readme.md

3c46442

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Update map/map_tf_generator/Readme.md

3795ab3

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

shmpwk force-pushed the feat/vector_map_tf_generator branch from 2a281c2 to 3795ab3 Compare July 5, 2022 11:46

kenji-miyake approved these changes Jul 5, 2022

View reviewed changes

shmpwk merged commit f33a859 into autowarefoundation:main Jul 5, 2022

shmpwk deleted the feat/vector_map_tf_generator branch July 5, 2022 14:26

tier4-autoware-public-bot bot mentioned this pull request Jul 6, 2022

chore: sync upstream tier4/autoware.universe#68

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(map_tf_generator)!: launching planning_simulator without pointcloud map #1216

feat(map_tf_generator)!: launching planning_simulator without pointcloud map #1216

shmpwk commented Jul 2, 2022 •

edited by kenji-miyake

Loading

codecov bot commented Jul 2, 2022 •

edited

Loading

yukkysaito left a comment

kenji-miyake left a comment

shmpwk commented Jul 5, 2022

kenji-miyake left a comment

feat(map_tf_generator)!: launching planning_simulator without pointcloud map #1216

feat(map_tf_generator)!: launching planning_simulator without pointcloud map #1216

Conversation

shmpwk commented Jul 2, 2022 • edited by kenji-miyake Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jul 2, 2022 • edited Loading

Codecov Report

yukkysaito left a comment

Choose a reason for hiding this comment

kenji-miyake left a comment

Choose a reason for hiding this comment

shmpwk commented Jul 5, 2022

kenji-miyake left a comment

Choose a reason for hiding this comment

shmpwk commented Jul 2, 2022 •

edited by kenji-miyake

Loading

codecov bot commented Jul 2, 2022 •

edited

Loading