Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(occupancy_grid): remove unecessary log #1217

Conversation

taikitanaka3
Copy link
Contributor

Signed-off-by: taikitanaka3 ttatcoder@outlook.jp

Description

change this debug message from warn to debug

"The origin for the sensor at (%.2f, %.2f) is out of map bounds. So, the costmap cannot "
      "raytrace for it."

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #1217 (1be6729) into main (0a17fe3) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1217   +/-   ##
=====================================
  Coverage   9.56%   9.56%           
=====================================
  Files       1049    1049           
  Lines      72114   72114           
  Branches   15604   15604           
=====================================
  Hits        6896    6896           
  Misses     58966   58966           
  Partials    6252    6252           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.54% <0.00%> (ø) Carriedforward from 0a17fe3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...an_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <0.00%> (ø)
...ud_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a17fe3...1be6729. Read the comment docs.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 51f7648 into autowarefoundation:main Jul 4, 2022
@taikitanaka3 taikitanaka3 deleted the chore/occupancy_grid_remove_unncessary_print branch July 4, 2022 02:53
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* chore(occupancy_grid): remove unecessary log

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* chore(occupancy_grid): remove unecessary log

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* chore(occupancy_grid): remove unecessary log

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* chore(occupancy_grid): remove unecessary log

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* chore(occupancy_grid): remove unecessary log

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants