Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): substitute input path initila point informaiton #1518

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 4, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Since current resamplePath function in motion utils miss some information in motion utils, I fix this bag in this PR. Currently, this function is not used by other modules, so there is no big influence in autoware.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 enabled auto-merge (squash) August 4, 2022 09:38
@taikitanaka3
Copy link
Contributor

@purewater0901
can you confirm that this PR can solve this kind of lane skipping case while generating resampled path and original path.
image

@purewater0901
Copy link
Contributor Author

How can I make this kind of scenario?

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1518 (64389ce) into main (7da6cd4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   10.57%   10.55%   -0.02%     
==========================================
  Files        1113     1113              
  Lines       78473    79362     +889     
  Branches    18331    18974     +643     
==========================================
+ Hits         8296     8377      +81     
- Misses      61513    62241     +728     
- Partials     8664     8744      +80     
Flag Coverage Δ *Carryforward flag
differential 10.81% <50.00%> (?)
total 10.55% <50.00%> (ø) Carriedforward from 7da6cd4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/resample/resample.cpp 55.92% <100.00%> (+7.74%) ⬆️
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 1.38% <0.00%> (+0.33%) ⬆️
...n/motion_utils/test/src/resample/test_resample.cpp 26.01% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Aug 4, 2022

@purewater0901
you can test with odaiba verification map in fms
i share you later

@purewater0901 purewater0901 merged commit 8bd7cff into autowarefoundation:main Aug 4, 2022
@purewater0901 purewater0901 deleted the feat/fix-resample-function branch August 4, 2022 10:26
tkimura4 referenced this pull request in tier4/autoware.universe Aug 4, 2022
HaoruXue pushed a commit to HaoruXue/autoware.universe that referenced this pull request Aug 10, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants