Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): use sampling functions from motion utils #1520

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 4, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Replace sampling functions in behavior velocity planner with sampling functions in motion utils.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…tils

Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1520 (63fe3e7) into main (0db51f5) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   10.62%   10.63%   +0.01%     
==========================================
  Files        1113     1113              
  Lines       78593    78639      +46     
  Branches    18424    18461      +37     
==========================================
+ Hits         8349     8363      +14     
- Misses      61516    61529      +13     
- Partials     8728     8747      +19     
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 10.60% <0.00%> (ø) Carriedforward from 0db51f5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...module/no_stopping_area/scene_no_stopping_area.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/utilization/path_utilization.cpp 18.18% <0.00%> (+5.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 49d91ff into autowarefoundation:main Aug 4, 2022
@purewater0901 purewater0901 deleted the feat/behavior-velocity-use-motion-utils branch August 4, 2022 23:05
@taikitanaka3
Copy link
Contributor

Note: it seems no Degradation so far with this commit using CI https://evaluation.tier4.jp/evaluation/reports?project_id=prd_jt

HaoruXue pushed a commit to HaoruXue/autoware.universe that referenced this pull request Aug 10, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants