refactor(mission_planner): prepare to support ad api

[isamu-takagi]

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Move the file for #1495

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #1561 (bbad499) into main (564dbb3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   10.74%   10.73%   -0.01%     
==========================================
  Files        1115     1117       +2     
  Lines       78815    78883      +68     
  Branches    18559    18559              
==========================================
  Hits         8465     8465              
- Misses      61630    61698      +68     
  Partials     8720     8720              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.72% <0.00%> (ø)		Carriedforward from ed80956

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp	0.00% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp	0.00% <ø> (ø)
...sion_planner_lanelet2/mission_planner_lanelet2.cpp	0.00% <0.00%> (ø)
...src/mission_planner_lanelet2/utility_functions.cpp	0.00% <ø> (ø)
...src/mission_planner_lanelet2/utility_functions.hpp	0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kenji-miyake]

This will stop using ComposableNodeContainer for mission_planner::MissionPlannerLanelet2 and mission_planner::GoalPoseVisualizer.
That may cause some performance degradation.
@yukkysaito @tkimura4 Is that okay for you?

FYI, from Humble, I believe we can use ComposableNode in launch.xml.

[isamu-takagi]

The goal pose visualizer node only subscribes to the route topic. This topic is only published once per setting route, so I don't think it will affect performance much.

[kenji-miyake]

Why did you move the header file? Please let me know if there are any references.
Do you want to create a guideline that says "all node header files should be under src/"?

[isamu-takagi]

if you are building a library, put all headers which should be usable by clients and therefore must be installed into a subdirectory of the include folder named like the package, while all other files (.c/.cpp and header files which should not be exported) are inside the src folder.

This is from guide of ament_cmake. This is not library header, so it should be placed under src. Now, many packages in Autoware put their private headers in include, so I think that should be a guideline.

[kenji-miyake]

Okay, thanks!
I'll write some documents based on ament_cmake's guidelines.