Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity): add insertDecel point function #1615

Merged

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 18, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

use insert decel point function as planning utils
#361

this PR changes

  • make insertDecelPoint function in util in behavior velocity planner and apply to occlusion spot module
  • insertDecelPoint To insertDecelPontWithDebugInfo which is equal to previous version.

remaining TODOs

  • interpolate yaw better way
  • consider overlap threshold of distance

note: insert decel point accuracy should be above 2e-5 in order not to insert odd point by using motion utils insertTargetPoint

  • before
simplescreenrecorder-2022-08-08_10.17.48.mp4
  • after
experiment-2022-08-18_14.27.41.mp4

internal link

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 marked this pull request as ready for review August 18, 2022 05:58
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1615 (9852ba9) into main (5772020) will increase coverage by 0.01%.
The diff coverage is 24.00%.

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
+ Coverage   10.77%   10.79%   +0.01%     
==========================================
  Files        1111     1111              
  Lines       78527    78725     +198     
  Branches    18552    18681     +129     
==========================================
+ Hits         8465     8495      +30     
- Misses      61203    61364     +161     
- Partials     8859     8866       +7     
Flag Coverage Δ *Carryforward flag
differential 4.70% <0.00%> (?)
total 10.76% <28.57%> (ø) Carriedforward from 5772020

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...vior_velocity_planner/include/utilization/util.hpp 0.00% <ø> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
..._module/occlusion_spot/risk_predictive_braking.cpp 52.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 22.75% <46.15%> (+3.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3 taikitanaka3 merged commit 90e4e78 into autowarefoundation:main Aug 18, 2022
@taikitanaka3 taikitanaka3 deleted the feature/add_insert_decel_function branch August 18, 2022 10:44
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1615)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
youtalk pushed a commit to youtalk/autoware.universe that referenced this pull request Nov 8, 2024
chore: sync tier4/autoware.universe:awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants