Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run_out): remove unused parameter #1836

Merged

Conversation

TomohitoAndo
Copy link
Contributor

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

Description

Removed unused parameter.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1836 (ccdb112) into main (cb2552b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
- Coverage   10.44%   10.43%   -0.01%     
==========================================
  Files        1221     1221              
  Lines       87728    87808      +80     
  Branches    20493    20541      +48     
==========================================
+ Hits         9160     9161       +1     
- Misses      69091    69167      +76     
- Partials     9477     9480       +3     
Flag Coverage Δ *Carryforward flag
differential 4.29% <0.00%> (?)
total 10.42% <0.00%> (ø) Carriedforward from cb2552b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
...ity_planner/include/scene_module/run_out/utils.hpp 0.00% <ø> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.70% <0.00%> (+0.28%) ⬆️
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

@taikitanaka3
could you review this PR?
I can't merge without code owner review. 🥺

@taikitanaka3
Copy link
Contributor

@TomohitoAndo
I didn't follow conversation but you don't use assumption of pedestrian velocity anymore?

@TomohitoAndo
Copy link
Contributor Author

@taikitanaka3
Parameters for that assumption are moved to here, so parameters removed in this PR are no longer needed.

min_vel_kmph: 0.0 # [km/h] minimum velocity for dynamic obstacles
max_vel_kmph: 5.0 # [km/h] maximum velocity for dynamic obstacles

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo enabled auto-merge (squash) September 14, 2022 05:35
@TomohitoAndo
Copy link
Contributor Author

ah, it seems review from @TakaHoribe is necessary...? 🤔
image

@TakaHoribe TakaHoribe self-requested a review September 14, 2022 06:36
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit e32d7d8 into autowarefoundation:main Sep 14, 2022
@TomohitoAndo TomohitoAndo deleted the run-out-remove-unused-param branch September 14, 2022 06:42
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants