Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add th_angle param #2067

Conversation

ismetatabay
Copy link
Member

Description

While the goal is published, the parameter is added for the maximum angle that the goal makes with the lane to be accepted.

Related links

#1761

Tests performed

When the goal was given, it was tried with 20, 30, 45 degrees to see whether the goal would reject or not. Since the value is 45 when no parameter is added, 45 was entered as the default value. (I think 20° better than 45°)

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ismetatabay ismetatabay deleted the feature/mission_planner_add_conf branch October 17, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant