Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component_state_monitor): add component state monitor #2120

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Oct 20, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Add component state monitor package. This package is an extract of ad_service_state_monitor's topic monitoring functionality.

Related links

tier4/tier4_autoware_msgs#61

Tests performed

  1. Check launch ready state topics are all true when Autoware is launched.
    ros2 topic echo /system/component_state_monitor/component/launch/<component>
  2. Check autonomous ready state of localization topic is true after initialpose.
    ros2 topic echo /system/component_state_monitor/component/autonomous/localization
  3. Check autonomous ready state of planning/control topics are true after route setting.
    ros2 topic echo /system/component_state_monitor/component/autonomous/planning
    ros2 topic echo /system/component_state_monitor/component/autonomous/control

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
error_rate: 1.0
timeout: 1.0

- module: sensing
Copy link
Contributor

@yukkysaito yukkysaito Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is perception because obstacle segmentation is part of perception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original setting is sensing. Can I change it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is moved from sensing to perception during the core/universe transplant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done fa5f106.

warn_rate: 5.0
error_rate: 1.0
timeout: 1.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can traffic light recognition results be added?

Copy link
Contributor Author

@isamu-takagi isamu-takagi Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the topic name and expected/error rate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In planning simulation, the topic was not published periodically, so I will merge it once. Please change the config if necessary.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If it works, it looks good to me for Autoware Universe.

For Autoware Core, @xmfcx is reconsidering a monitoring architecture, so we should discuss it later.
autowarefoundation/autoware.core#57

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants