-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component_state_monitor): add component state monitor #2120
feat(component_state_monitor): add component state monitor #2120
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
error_rate: 1.0 | ||
timeout: 1.0 | ||
|
||
- module: sensing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is perception because obstacle segmentation is part of perception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original setting is sensing. Can I change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It is moved from sensing to perception during the core/universe transplant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done fa5f106.
warn_rate: 5.0 | ||
error_rate: 1.0 | ||
timeout: 1.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can traffic light recognition results be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the topic name and expected/error rate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In planning simulation, the topic was not published periodically, so I will merge it once. Please change the config if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If it works, it looks good to me for Autoware Universe.
For Autoware Core, @xmfcx is reconsidering a monitoring architecture, so we should discuss it later.
autowarefoundation/autoware.core#57
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Add component state monitor package. This package is an extract of ad_service_state_monitor's topic monitoring functionality.
Related links
tier4/tier4_autoware_msgs#61
Tests performed
ros2 topic echo /system/component_state_monitor/component/launch/<component>
ros2 topic echo /system/component_state_monitor/component/autonomous/localization
ros2 topic echo /system/component_state_monitor/component/autonomous/planning
ros2 topic echo /system/component_state_monitor/component/autonomous/control
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.