Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): move interpolated path to PlannerData #2177

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 30, 2022

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 10.82% // Head: 10.74% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (db76ddd) compared to base (e009b13).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
- Coverage   10.82%   10.74%   -0.08%     
==========================================
  Files        1178     1178              
  Lines       84624    85349     +725     
  Branches    19947    20465     +518     
==========================================
+ Hits         9159     9170      +11     
- Misses      65756    66403     +647     
- Partials     9709     9776      +67     
Flag Coverage Δ *Carryforward flag
differential 4.25% <0.00%> (?)
total 10.80% <0.00%> (ø) Carriedforward from e009b13

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.54% <0.00%> (+0.12%) ⬆️
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...module/no_stopping_area/scene_no_stopping_area.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/run_out/dynamic_obstacle.cpp 0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@autowarefoundation autowarefoundation locked and limited conversation to collaborators Oct 31, 2022
@soblin soblin closed this Dec 8, 2022
@soblin soblin deleted the refactor/move-spline-to-planner-data branch December 23, 2022 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant