fix(default_ad_api): change motion state transition

[isamu-takagi]

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Fix a bug in motion state that prevented vehicle from starting.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 10.84% // Head: 10.81% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (26f790e) compared to base (4fcc6da).
Patch coverage: 21.31% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
- Coverage   10.84%   10.81%   -0.03%     
==========================================
  Files        1178     1178              
  Lines       84781    84654     -127     
  Branches    19950    19947       -3     
==========================================
- Hits         9196     9159      -37     
+ Misses      66016    65786     -230     
- Partials     9569     9709     +140     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.80% <25.74%> (-0.03%)	⬇️	Carriedforward from 5e418b1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...nterface/include/osqp_interface/osqp_interface.hpp	0.00% <0.00%> (ø)
..._localizer/include/ekf_localizer/ekf_localizer.hpp	0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp	0.00% <0.00%> (ø)
system/default_ad_api/src/motion.cpp	10.98% <12.96%> (-5.41%)	⬇️
common/osqp_interface/src/osqp_interface.cpp	35.39% <47.36%> (ø)
common/osqp_interface/test/test_osqp_interface.cpp	17.24% <100.00%> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp	50.00% <0.00%> (-35.72%)	⬇️
...ng/behavior_path_planner/test/test_turn_signal.cpp	27.60% <0.00%> (-12.81%)	⬇️
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TakaHoribe]

Confirmed the bug is fixed by this PR.