Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(map_loader): add maintainer #2245

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 8, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Add maintainer in map loader

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 11.15% // Head: 11.15% // No change to project coverage 👍

Coverage data is based on head (737d8e2) compared to base (a1adc88).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2245   +/-   ##
=======================================
  Coverage   11.15%   11.15%           
=======================================
  Files        1200     1200           
  Lines       86183    86183           
  Branches    20786    20786           
=======================================
  Hits         9614     9614           
  Misses      66442    66442           
  Partials    10127    10127           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.12% <ø> (ø) Carriedforward from a1adc88

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda merged commit da9e5f0 into autowarefoundation:main Nov 8, 2022
@kminoda kminoda deleted the chore/add_map_loader_maintainer branch November 30, 2022 00:13
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
* chore(map_loader): add maintainer

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove miyake-san

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
* chore(map_loader): add maintainer

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove miyake-san

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants