-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" #2289
fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" #2289
Conversation
Signed-off-by: jack.song <jack.song@autocore.ai>
Codecov ReportBase: 11.12% // Head: 11.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2289 +/- ##
==========================================
- Coverage 11.12% 11.06% -0.07%
==========================================
Files 1200 1201 +1
Lines 86198 86701 +503
Branches 20793 21041 +248
==========================================
Hits 9593 9593
- Misses 66479 66950 +471
- Partials 10126 10158 +32
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
LGTM!
…moother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…moother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…moother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…moother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai>
…tion#2157) Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> chore: remove motion_common dependency (autowarefoundation#2231) * remove motion_common from smoother Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove motion_common from control_performance_analysis and simple_planning_simualtor Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix include Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add include Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> refactor(motion_velocity_smoother): remove unused optional (autowarefoundation#1906) * remove unused optional Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * pre-commit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> add tunable deccel limit before curve fix(motion_velocity_smoother): mismatch of v0/a0 between optimization and external velocity limit (autowarefoundation#2283) * fix(motion_velocity_smoother): inconsistent v0/a0 between optimization and external velocity limit Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove debug print Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" (autowarefoundation#2289) fix-l2-smoother Signed-off-by: jack.song <jack.song@autocore.ai> Signed-off-by: jack.song <jack.song@autocore.ai> chore(motion_velocity_smoother): add debug print for non-supported function (autowarefoundation#2298) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> fix(motion_velocity_smoother): add current_closest_point_from_prev_output (autowarefoundation#2399) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> increase distance before curve update delay compansation
Signed-off-by: jack.song jack.song@autocore.ai
Description
By this PR,the ‘l2_pseudo_jerk_smoother’ can take normal time to start and accelerate normally when the speed is reduced to low value.
Related links
#2211
Tests performed
Simulation by now:
(1)When the car is turning,the speed can not accelerate normally after the speed is reduced.
(2)The car can take long time to start
l2_start_now.mp4
Simulation after changing:
(1)When the car is turning,the speed is normal:
(2)The car can take normal time to start
l2_change.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.