Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" #2289

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" #2289

merged 1 commit into from
Nov 15, 2022

Conversation

shulanbushangshu
Copy link
Contributor

Signed-off-by: jack.song jack.song@autocore.ai

Description

By this PR,the ‘l2_pseudo_jerk_smoother’ can take normal time to start and accelerate normally when the speed is reduced to low value.

Related links

#2211

Tests performed

Simulation by now:
(1)When the car is turning,the speed can not accelerate normally after the speed is reduced.

l2turnerr

(2)The car can take long time to start

l2_start_now.mp4

Simulation after changing:
(1)When the car is turning,the speed is normal:
l2turing
(2)The car can take normal time to start

l2_change.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: jack.song <jack.song@autocore.ai>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 11.12% // Head: 11.06% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (405cd00) compared to base (d3768c4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   11.12%   11.06%   -0.07%     
==========================================
  Files        1200     1201       +1     
  Lines       86198    86701     +503     
  Branches    20793    21041     +248     
==========================================
  Hits         9593     9593              
- Misses      66479    66950     +471     
- Partials    10126    10158      +32     
Flag Coverage Δ *Carryforward flag
differential 3.57% <0.00%> (?)
total 11.10% <0.00%> (ø) Carriedforward from d3768c4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp 0.00% <0.00%> (ø)
planning/motion_velocity_smoother/src/resample.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <0.00%> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)
...y_planner/include/utilization/trajectory_utils.hpp 0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...elocity_smoother/motion_velocity_smoother_node.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
LGTM!

@rej55 rej55 merged commit e68b48d into autowarefoundation:main Nov 15, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…moother" (autowarefoundation#2289)

fix-l2-smoother

Signed-off-by: jack.song <jack.song@autocore.ai>

Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…moother" (autowarefoundation#2289)

fix-l2-smoother

Signed-off-by: jack.song <jack.song@autocore.ai>

Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…moother" (autowarefoundation#2289)

fix-l2-smoother

Signed-off-by: jack.song <jack.song@autocore.ai>

Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
brkay54 pushed a commit to vautonomous/autoware.universe that referenced this pull request Jan 28, 2023
…moother" (autowarefoundation#2289)

fix-l2-smoother

Signed-off-by: jack.song <jack.song@autocore.ai>

Signed-off-by: jack.song <jack.song@autocore.ai>
voltonomous added a commit to vautonomous/autoware.universe that referenced this pull request Jan 28, 2023
…tion#2157)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
chore: remove motion_common dependency (autowarefoundation#2231)

* remove motion_common from smoother

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove motion_common from control_performance_analysis and simple_planning_simualtor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix include

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add include

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
refactor(motion_velocity_smoother): remove unused optional (autowarefoundation#1906)

* remove unused optional

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* pre-commit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
add tunable deccel limit before curve


fix(motion_velocity_smoother): mismatch of v0/a0 between optimization and external velocity limit (autowarefoundation#2283)

* fix(motion_velocity_smoother): inconsistent v0/a0 between optimization and external velocity limit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* remove debug print

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
fix(motion_velocity_smoother): fix taking long time to start in "l2_smoother" (autowarefoundation#2289)

fix-l2-smoother

Signed-off-by: jack.song <jack.song@autocore.ai>

Signed-off-by: jack.song <jack.song@autocore.ai>
chore(motion_velocity_smoother): add debug print for non-supported function (autowarefoundation#2298)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
fix(motion_velocity_smoother): add current_closest_point_from_prev_output (autowarefoundation#2399)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
increase distance before curve


update delay compansation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants