Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API #2433

Merged
merged 9 commits into from
Dec 2, 2022
Merged

feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API #2433

merged 9 commits into from
Dec 2, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Dec 2, 2022 •
edited
Loading

Description

  • use ADAPI v1 instead of old API
  • delete path change approval because RTC is now providing same function.

image

Related links

TIERIV_INTERNAL_LINK: https://tier4.atlassian.net/browse/T4PB-24038

Tests performed

In planning_simulator

  • set ego and goal position
  • click auto button and ego is driving.
  • click stop and ego is stopping

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta
fix: delete path change approval
cd3fa9a 
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta
make operation and control mode layout
a368fb7 
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta requested a review from a team as a code owner December 2, 2022 02:58
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 2, 2022
@h-ohta h-ohta force-pushed the feat/adapi_autoware_state_panel branch from a13181f to 86646cb Compare December 2, 2022 03:00
@codecov
Copy link

codecov bot commented Dec 2, 2022 •
edited
Loading

Codecov Report

Base: 10.45% // Head: 10.45% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f4495c5) compared to base (a7270a8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2433      +/-   ##
==========================================
- Coverage   10.45%   10.45%   -0.01%     
==========================================
  Files        1261     1261              
  Lines       92080    92139      +59     
  Branches    21123    21123              
==========================================
  Hits         9630     9630              
- Misses      72242    72301      +59     
  Partials    10208    10208
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from 8d8b0e1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta force-pushed the feat/adapi_autoware_state_panel branch from 86646cb to 7fd7ccf Compare December 2, 2022 04:20
@isamu-takagi
Copy link
Contributor

@h-ohta Can you add a display for is_in_transition?

@h-ohta
Copy link
Contributor Author

h-ohta commented Dec 2, 2022

I added Transition status.

isamu-takagi
isamu-takagi approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@h-ohta h-ohta enabled auto-merge (squash) December 2, 2022 08:11
@h-ohta h-ohta disabled auto-merge December 2, 2022 08:55
@h-ohta h-ohta merged commit 0f37fdb into autowarefoundation:main Dec 2, 2022
@h-ohta h-ohta deleted the feat/adapi_autoware_state_panel branch December 2, 2022 08:56
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 3, 2022
Merged
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 5, 2022
@soblin
Revert "feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API (
a151a48 
autowarefoundation#2433)"

This reverts commit 0f37fdb.
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Dec 9, 2022
@h-ohta @1222-takeshi
feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API (autow…
7596c72 
…arefoundation#2433)

* fix: delete path change approval

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* make operation and control mode layout

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* add nullptr

* fix pre-commit

* fix comment

* fix: rename enable disable

* feat: add TRANSITION

* fix comment

* delete unused

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Dec 14, 2022
@h-ohta @TomohitoAndo
feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API (autow…
baada1e 
…arefoundation#2433)

* fix: delete path change approval

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* make operation and control mode layout

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* add nullptr

* fix pre-commit

* fix comment

* fix: rename enable disable

* feat: add TRANSITION

* fix comment

* delete unused

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@TomohitoAndo TomohitoAndo mentioned this pull request Dec 14, 2022
Merged
4 tasks
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@h-ohta @HansRobo
feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API (autow…
92f2db3 
…arefoundation#2433)

* fix: delete path change approval

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* make operation and control mode layout

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* add nullptr

* fix pre-commit

* fix comment

* fix: rename enable disable

* feat: add TRANSITION

* fix comment

* delete unused

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
@h-ohta @kminoda
feat(tier4_state_rviz_plugin): use ADAPI v1 instead of old API (autow…
2ffaf20 
…arefoundation#2433)

* fix: delete path change approval

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* make operation and control mode layout

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* add nullptr

* fix pre-commit

* fix comment

* fix: rename enable disable

* feat: add TRANSITION

* fix comment

* delete unused

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taikitanaka3 taikitanaka3 taikitanaka3 left review comments

@isamu-takagi isamu-takagi isamu-takagi approved these changes

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-ohta @isamu-takagi @taikitanaka3