Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): candidate path header #2536

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 20, 2022

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

If the header of candidate_path_ is not set, it is not visualized, because the header of output is replaced with input by util::toPath()

Related links

#2486

Tests performed

psim

Screenshot from 2022-12-20 17-23-09

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review December 20, 2022 08:34
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 20, 2022
@kosuke55
Copy link
Contributor Author

FYI: before #2486, the header of candidate is current one.

image

@kosuke55
Copy link
Contributor Author

@rej55
Could you please check this PR?:pray:

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@kosuke55 kosuke55 enabled auto-merge (squash) December 20, 2022 08:51
@kosuke55 kosuke55 merged commit fb4164f into autowarefoundation:main Dec 20, 2022
@kosuke55 kosuke55 deleted the fix/candidate_path branch December 20, 2022 09:11
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
…#2536)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…#2536)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants