Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_departure_checker): check shoulder lane #2614

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 5, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

check shoulder lanes in lane_departure_checker.

the yellow marker is the target candidate lanes, it includes shoulder lanes.

ego is in the shoulder lane
Screenshot from 2023-01-05 23-08-10

ego is out of the shoulder lane
Screenshot from 2023-01-05 23-08-41

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review January 5, 2023 14:13
@kosuke55 kosuke55 requested review from kyoichi-sugahara and a team as code owners January 5, 2023 14:13
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 11.49% // Head: 11.48% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (fdb828c) compared to base (316f5e9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   11.49%   11.48%   -0.02%     
==========================================
  Files        1271     1271              
  Lines       88412    88535     +123     
  Branches    23314    23407      +93     
==========================================
+ Hits        10164    10165       +1     
- Misses      67476    67581     +105     
- Partials    10772    10789      +17     
Flag Coverage Δ *Carryforward flag
differential 4.94% <0.00%> (?)
total 11.49% <0.00%> (ø) Carriedforward from 316f5e9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
..._departure_checker_node/lane_departure_checker.cpp 0.00% <0.00%> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.61% <0.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55
Copy link
Contributor Author

@kyoichi-sugahara
Could you please check this PR?:pray:

@kosuke55 kosuke55 merged commit 966ef94 into main Jan 12, 2023
@kosuke55 kosuke55 deleted the feat/shoulder_lane_departure_checker branch January 12, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants