fix(lane_change): get sorted lane ids #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportBase: 11.62% // Head: 11.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2847 +/- ##
==========================================
- Coverage 11.62% 11.59% -0.04%
==========================================
Files 1321 1321
Lines 92140 92392 +252
Branches 24443 24612 +169
==========================================
Hits 10714 10714
- Misses 70244 70482 +238
- Partials 11182 11196 +14
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 9, 2023
* fix(lane_change): get sorted lane ids Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slightly change the find Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
This was referenced Feb 9, 2023
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 9, 2023
* fix(lane_change): get sorted lane ids * slightly change the find --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the generated lane change points lane ids are not properly sorted.
Ideally the lane ids should be sorted as follow
This PR aims to solve this by properly having a sorted lane ids.
Related links
#2836
Tests performed
Test lane change function and it is expected that it behave as usual.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.