Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route_handler): route plan failed when ego is on the road shoulder #4255

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 12, 2023

Description

Fix for #4254.

Modify the code in the route_handler to enable route plan when the ego is located out of the road_lanelet (e.g. road shoulder).

Related links

#4254

Tests performed

Notes for reviewers

None

Interface changes

None

Effects on system behavior

The route planning behavior changes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (67c95e9) 14.21% compared to head (c910256) 14.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4255      +/-   ##
==========================================
- Coverage   14.21%   14.18%   -0.03%     
==========================================
  Files        1597     1597              
  Lines      109846   110243     +397     
  Branches    31508    31788     +280     
==========================================
+ Hits        15613    15639      +26     
- Misses      77282    77641     +359     
- Partials    16951    16963      +12     
Flag Coverage Δ *Carryforward flag
differential 16.24% <0.00%> (?)
total 14.21% <ø> (ø) Carriedforward from 67c95e9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_planner/src/lanelet2_plugins/default_planner.cpp 22.00% <0.00%> (-0.11%) ⬇️
planning/route_handler/src/route_handler.cpp 24.74% <0.00%> (-0.06%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@TakaHoribe TakaHoribe merged commit 4d9d98f into autowarefoundation:main Jul 12, 2023
@TakaHoribe TakaHoribe deleted the fix-route-sholder branch July 12, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants