Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): move isLaneChangePathSafe to normal lane change class #4260

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 12, 2023

Description

Move the isLaneChangePathSafe function to the normal lane change class to clean the code

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 1.01% and project coverage change: -0.01 ⚠️

Comparison is base (0752672) 15.21% compared to head (583199e) 15.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
- Coverage   15.21%   15.21%   -0.01%     
==========================================
  Files        1489     1489              
  Lines      102610   102643      +33     
  Branches    31518    31523       +5     
==========================================
+ Hits        15613    15615       +2     
- Misses      70046    70077      +31     
  Partials    16951    16951              
Flag Coverage Δ *Carryforward flag
differential 13.63% <1.01%> (?)
total 15.22% <ø> (+0.01%) ⬆️ Carriedforward from 0752672

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...r_path_planner/utils/path_shifter/path_shifter.hpp 0.00% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 5.18% <0.00%> (-0.45%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.37% <ø> (+0.02%) ⬆️
...th_planner/src/utils/path_shifter/path_shifter.cpp 6.71% <0.00%> (-0.08%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.66% <2.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@purewater0901 purewater0901 merged commit 56f1943 into main Jul 13, 2023
@purewater0901 purewater0901 deleted the refactor/move-is-lane-change-path-safe branch July 13, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants