refactor(lane_change): move several functions from lane change utils to NormalLaneChange #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4273 +/- ##
==========================================
- Coverage 15.20% 15.18% -0.03%
==========================================
Files 1489 1489
Lines 102660 102670 +10
Branches 31529 31527 -2
==========================================
- Hits 15611 15586 -25
- Misses 70097 70141 +44
+ Partials 16952 16943 -9
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp
Outdated
Show resolved
Hide resolved
purewater0901
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 19, 2023
…to NormalLaneChange (autowarefoundation#4273) * refactor(lane_change): move getPrepareSegment to a class function Signed-off-by: yutaka <purewater0901@gmail.com> * move hasEnoughLength function to NormalLaneChange Signed-off-by: yutaka <purewater0901@gmail.com> * udpate Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to reduce the arguments in the
getPrepareSegment,hasEnoughLengthandgetTargetObjects, I moved them to theNormalLaneChangeclass. Therefore, it has two less arguments than before. Moreover, I removed a singlemaybe unusedflag to clean the code.Tests performed
1577/1588
TIER IV Internal Link
Effects on system behavior
No effects.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.