Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map_loader): fix spell-check #4280

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 14, 2023

Description

Fix spell-check

Related links

N/A

Tests performed

N/A

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jul 14, 2023
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0443a08) 14.36% compared to head (d02cd46) 14.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4280   +/-   ##
=======================================
  Coverage   14.36%   14.36%           
=======================================
  Files        1567     1567           
  Lines      107877   107877           
  Branches    31249    31249           
=======================================
  Hits        15498    15498           
  Misses      75525    75525           
  Partials    16854    16854           
Flag Coverage Δ *Carryforward flag
differential 26.26% <ø> (?)
total 14.36% <ø> (ø) Carriedforward from 0443a08

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._loader/test/test_pointcloud_map_loader_module.cpp 46.34% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda merged commit e282c4f into autowarefoundation:main Jul 14, 2023
@kminoda kminoda deleted the fix/map_loader/spell-check branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants