Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): set stop path drivable area #4297

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 17, 2023

Description

Use generateStopOutput instead of generateStopPath because it do not genete drivable area.

image

Related links

Tests performed

psim

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (76c61de) 14.18% compared to head (cb0fd4f) 14.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4297   +/-   ##
=======================================
  Coverage   14.18%   14.18%           
=======================================
  Files        1599     1599           
  Lines      110048   110045    -3     
  Branches    31538    31537    -1     
=======================================
  Hits        15609    15609           
+ Misses      77485    77482    -3     
  Partials    16954    16954           
Flag Coverage Δ *Carryforward flag
differential 13.58% <0.00%> (?)
total 14.18% <ø> (+<0.01%) ⬆️ Carriedforward from 76c61de

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...cene_module/start_planner/start_planner_module.cpp 4.03% <0.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 361fbaf into main Jul 17, 2023
@kosuke55 kosuke55 deleted the fix/start_planner_stop_path_drivable_area branch July 17, 2023 12:09
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Aug 28, 2023
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants