-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(object_merger): preserve unknown objects close to known objects #4499
fix(object_merger): preserve unknown objects close to known objects #4499
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@badai-nguyen Could you also modify this config https://github.com/autowarefoundation/autoware.universe/blob/main/perception/object_merger/config/overlapped_judge.param.yaml ? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
- Coverage 14.89% 14.89% -0.01%
==========================================
Files 1520 1520
Lines 104910 104912 +2
Branches 31958 31958
==========================================
Hits 15623 15623
- Misses 72222 72224 +2
Partials 17065 17065
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#4499) * fix(object_merger): separate GIoU Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: update GIoU threshold Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…utowarefoundation#4499) * fix(object_merger): separate GIoU Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: update GIoU threshold Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…utowarefoundation#4499) * fix(object_merger): separate GIoU Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: update GIoU threshold Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
Related link
TIER IV INTERNAL LINK
Tests performed
Some traffic cones detection near by truck was confirmed by internal rosbag.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.