Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object_merger): preserve unknown objects close to known objects #4499

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Aug 2, 2023

Description

  • This PR aims to separate GIoU thresholds for each class when determining whether unknown objects are overlapped with known objects or how far unknown objects are from known objects to enable merging.
  • This also could solve issue object_merger removes obsacles around known object #4425

Related link

TIER IV INTERNAL LINK

Tests performed

Some traffic cones detection near by truck was confirmed by internal rosbag.
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Aug 2, 2023
@badai-nguyen badai-nguyen changed the title fix(object_merger): preserve unknown objects close to unknown objects fix(object_merger): preserve unknown objects close to known objects Aug 2, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review August 2, 2023 07:35
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 2, 2023
@miursh
Copy link
Contributor

miursh commented Aug 2, 2023

@badai-nguyen Could you also modify this config https://github.com/autowarefoundation/autoware.universe/blob/main/perception/object_merger/config/overlapped_judge.param.yaml ?

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (0becdc6) 14.89% compared to head (a8baff3) 14.89%.
Report is 9 commits behind head on main.

❗ Current head a8baff3 differs from pull request most recent head ad121ab. Consider uploading reports for the commit ad121ab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4499      +/-   ##
==========================================
- Coverage   14.89%   14.89%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      104910   104912       +2     
  Branches    31958    31958              
==========================================
  Hits        15623    15623              
- Misses      72222    72224       +2     
  Partials    17065    17065              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 0becdc6

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._merger/include/object_association_merger/node.hpp 0.00% <ø> (ø)
...ject_merger/src/object_association_merger/node.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen
Copy link
Contributor Author

@miursh I have updated overlapped_judge config here ad121ab

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 37c80ad into autowarefoundation:main Aug 2, 2023
19 of 20 checks passed
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Aug 3, 2023
…utowarefoundation#4499)

* fix(object_merger): separate GIoU

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: update GIoU threshold

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…utowarefoundation#4499)

* fix(object_merger): separate GIoU

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: update GIoU threshold

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
TakuIwasaki pushed a commit to TakuIwasaki/autoware.universe that referenced this pull request Feb 29, 2024
…utowarefoundation#4499)

* fix(object_merger): separate GIoU

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: update GIoU threshold

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants