Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(merge_from_private): use separate param #4692

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 22, 2023

Description

Declare a separate parameter for stop_line_margin of merge_from_private

Related links

https://tier4.atlassian.net/browse/RT0-28829

autowarefoundation/autoware_launch#521

Tests performed

Psim

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 22, 2023
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (daa3785) 14.89% compared to head (cc3b90c) 14.89%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4692   +/-   ##
=======================================
  Coverage   14.89%   14.89%           
=======================================
  Files        1549     1549           
  Lines      106955   106955           
  Branches    32790    32790           
=======================================
  Hits        15927    15927           
  Misses      73635    73635           
  Partials    17393    17393           
Flag Coverage Δ *Carryforward flag
differential 7.10% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from daa3785

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 19.13% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit c09441b into autowarefoundation:main Aug 22, 2023
31 of 33 checks passed
@soblin soblin deleted the feat/merge_from_private/distance-param branch August 22, 2023 04:43
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
feat(merge_from_private): use separate param (autowarefoundation#4692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants