Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception_rviz_plugin): only delete markers with unused MarkersIDs during updates. #4783

Merged

style(pre-commit): autofix

964b418
Select commit
Loading
Failed to load commit list.
Merged

refactor(perception_rviz_plugin): only delete markers with unused MarkersIDs during updates. #4783

style(pre-commit): autofix
964b418
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Aug 28, 2023 in 35s

CodeScene PR Check

Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Negative Code Health Impact (highest to lowest):

  • Bumpy Road Ahead predicted_objects_display.cpp: PredictedObjectsDisplay::update

Annotations

Check warning on line 211 in common/autoware_auto_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

PredictedObjectsDisplay::update has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.