refactor(goal_planner): rebuild state transition #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
tag:run-build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5371 +/- ##
==========================================
+ Coverage 14.76% 14.79% +0.03%
==========================================
Files 1662 1662
Lines 115450 115619 +169
Branches 35635 35744 +109
==========================================
+ Hits 17047 17107 +60
- Misses 79178 79264 +86
- Partials 19225 19248 +23
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
4 tasks
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
…sition (autowarefoundation#5371)" (autowarefoundation#5399) This reverts commit 3d2a7f6.
4 tasks
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (autowarefoundation#5371)" (autowarefoundation#5399)
7 tasks
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
7 tasks
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 27, 2023
HansOersted
pushed a commit
that referenced
this pull request
Nov 14, 2023
…5417) * refactor(goal_planner): rebuild state transition (#5371)" (#5399)" This reverts commit 92f78a4. * fix: increment path idx Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * refactor Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Zhe Shen <lucidshenzhe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rebuild goal planner state transition related to
#4518
Related links
#4518
Tests performed
psim
https://evaluation.tier4.jp/evaluation/reports/a902cb9b-8fb4-5109-937b-b18912cda2e7?project_id=prd_jt
evaluator_description: refactor/goal_planner_state
2023/10/23 https://evaluation.tier4.jp/evaluation/reports/3975f175-2957-554e-a021-d617dfa35158/?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=cb497016-2e2f-4ce0-9ac8-68d77a27a55d&filter=&job_id=fee28b13-55cd-5606-882e-b5c476037840&project_id=prd_jt&table_config=date%2Chide&target_ids=8cdcf567-81a6-59db-81f7-f533153b3e57
Notes for reviewers
none
Interface changes
none
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.