Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): accurate decision of front vehicle to avoid #5679

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 25, 2023

Description

The front vehicle decision whether to avoid or not is wrong sometimes as shown in the following figure.
This PR fixed the issue by calculating how much ratio the object covers the ego's path.

before
The dynamic avoidance module tries to avoid the front vehicle unexpectedly.
image

after
image

Tests performed

psim

Effects on system behavior

accurate front vehicle decision for dynamic avoidance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review November 25, 2023 16:40
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 1370 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (0ca9f9f) 12.52%.
Report is 70 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 4.27% 169 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.65% 150 Missing and 2 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% 54 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.01% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 2.27% 41 Missing and 2 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 13.63% 15 Missing and 4 partials ⚠️
.../utils/goal_planner/default_fixed_goal_planner.cpp 0.00% 19 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5679       +/-   ##
===========================================
- Coverage   15.32%   12.52%    -2.80%     
===========================================
  Files        1721      107     -1614     
  Lines      118559    15100   -103459     
  Branches    37995     8458    -29537     
===========================================
- Hits        18169     1892    -16277     
+ Misses      79657    10246    -69411     
+ Partials    20733     2962    -17771     
Flag Coverage Δ
differential 12.52% <10.63%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 1eb962e into autowarefoundation:main Nov 27, 2023
20 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-front-vehicle-avoid branch November 27, 2023 04:56
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 27, 2023
…utowarefoundation#5679)

* feat(dynamic_avoidance): accurate decision of front vehicle to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…utowarefoundation#5679)

* feat(dynamic_avoidance): accurate decision of front vehicle to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…utowarefoundation#5679)

* feat(dynamic_avoidance): accurate decision of front vehicle to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants