-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pid_longitudinal_controller): change INFO printing frequency #5890
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:chore/pid-rclcpp-info
Dec 28, 2023
Merged
chore(pid_longitudinal_controller): change INFO printing frequency #5890
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:chore/pid-rclcpp-info
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
label
Dec 16, 2023
takayuki5168
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
=======================================
Coverage 15.30% 15.30%
=======================================
Files 1747 1747
Lines 120123 120029 -94
Branches 36573 36518 -55
=======================================
- Hits 18380 18367 -13
+ Misses 81128 81065 -63
+ Partials 20615 20597 -18
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
force-pushed
the
chore/pid-rclcpp-info
branch
from
December 18, 2023 11:17
e628030
to
27360a5
Compare
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…utowarefoundation#5890) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5890) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5890) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#5890) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, this message is shown always after the ego reaches the goal in some cases, resulting in the messy terminal.
It's enough to show this message only once for each case (e.g. During moving the steering angle to the target when the ego is stopped, it's enough to show this message only once.).
This PR makes the message shown only once for each case.
Tests performed
psim
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.