Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pid_longitudinal_controller): change INFO printing frequency #5890

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 16, 2023

Description

For some reason, this message is shown always after the ego reaches the goal in some cases, resulting in the messy terminal.
It's enough to show this message only once for each case (e.g. During moving the steering angle to the target when the ego is stopped, it's enough to show this message only once.).

This PR makes the message shown only once for each case.

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Dec 16, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 16, 2023 05:39
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0b58725) 15.30% compared to head (27360a5) 15.30%.
Report is 12 commits behind head on main.

Files Patch % Lines
...nal_controller/src/pid_longitudinal_controller.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5890   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files        1747     1747           
  Lines      120123   120029   -94     
  Branches    36573    36518   -55     
=======================================
- Hits        18380    18367   -13     
+ Misses      81128    81065   -63     
+ Partials    20615    20597   -18     
Flag Coverage Δ *Carryforward flag
differential 41.08% <66.66%> (?)
total 15.30% <ø> (-0.01%) ⬇️ Carriedforward from 0b58725

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 1c42fbe into autowarefoundation:main Dec 28, 2023
23 of 24 checks passed
@takayuki5168 takayuki5168 deleted the chore/pid-rclcpp-info branch December 28, 2023 16:27
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants