Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(avoidance): remove unused header #5907

Merged
merged 5 commits into from
Dec 21, 2023
Merged

refactor(avoidance): remove unused header #5907

merged 5 commits into from
Dec 21, 2023

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 19, 2023 •
edited by satoshi-ota
Loading

Description

Remove unused header in avoidance module.
Also apply some very minor changes based on clang-tidy.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 19, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (acf7e51) 15.28% compared to head (2009eef) 15.29%.
Report is 9 commits behind head on main.

Files Patch % Lines
...de/behavior_path_avoidance_module/data_structs.hpp 0.00% 2 Missing ⚠️
...e/include/behavior_path_avoidance_module/scene.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5907      +/-   ##
==========================================
+ Coverage   15.28%   15.29%   +0.01%     
==========================================
  Files        1749     1748       -1     
  Lines      120356   120250     -106     
  Branches    36708    36642      -66     
==========================================
- Hits        18401    18397       -4     
+ Misses      81305    81243      -62     
+ Partials    20650    20610      -40
Flag Coverage Δ *Carryforward flag
differential 13.34% <20.00%> (?)
total 15.30% <ø> (+0.01%) ⬆️ Carriedforward from 9b6c60a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4
refactor(avoidance): remove unused header
79b4c23 
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
remove libboost-dev dependencies
247555f 
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
removed unused variable. add slight clang-tidy suggestion
9b6c60a 
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@satoshi-ota satoshi-ota self-requested a review December 20, 2023 05:52
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) December 20, 2023 09:09
@satoshi-ota
Copy link
Contributor

Fix conflicts.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 18f124e into autowarefoundation:main Dec 21, 2023
25 of 26 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 10, 2024
Merged
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
@zulfaqar-azmi-t4 @satoshi-ota
refactor(avoidance): remove unused header (autowarefoundation#5907)
0907d0b 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
@zulfaqar-azmi-t4 @TomohitoAndo
refactor(avoidance): remove unused header (autowarefoundation#5907)
56b8345 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
@zulfaqar-azmi-t4 @satoshi-ota
refactor(avoidance): remove unused header (autowarefoundation#5907)
1c93dcc 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@zulfaqar-azmi-t4 @karishma1911
refactor(avoidance): remove unused header (autowarefoundation#5907)
fc03a19 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@zulfaqar-azmi-t4 @karishma1911
refactor(avoidance): remove unused header (autowarefoundation#5907)
4d63c4a 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@zulfaqar-azmi-t4 @karishma1911
refactor(avoidance): remove unused header (autowarefoundation#5907)
84f1a84 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@zulfaqar-azmi-t4 @karishma1911
refactor(avoidance): remove unused header (autowarefoundation#5907)
e26a39c 
* refactor(avoidance): remove unused header

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* remove libboost-dev dependencies

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* removed unused variable. add slight clang-tidy suggestion

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-avoidance-header branch June 18, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@rej55 rej55 Awaiting requested review from rej55

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

@shmpwk shmpwk Awaiting requested review from shmpwk

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees

@satoshi-ota satoshi-ota

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zulfaqar-azmi-t4 @satoshi-ota