Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): use new interface for state #5950

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 24, 2023

Description

Support new state for lane change modules.

Related links

Tests performed

Evaluator result

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (2e2f184) 15.28% compared to head (4ec99af) 15.33%.
Report is 9 commits behind head on main.

Files Patch % Lines
...behavior_path_lane_change_module/src/interface.cpp 0.00% 69 Missing ⚠️
...ing/behavior_path_lane_change_module/src/scene.cpp 0.00% 7 Missing ⚠️
...path_avoidance_by_lane_change_module/src/scene.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5950      +/-   ##
==========================================
+ Coverage   15.28%   15.33%   +0.05%     
==========================================
  Files        1750     1750              
  Lines      120432   121379     +947     
  Branches    36729    37399     +670     
==========================================
+ Hits        18404    18613     +209     
- Misses      81375    81968     +593     
- Partials    20653    20798     +145     
Flag Coverage Δ *Carryforward flag
differential 11.80% <0.00%> (?)
total 15.28% <ø> (+<0.01%) ⬆️ Carriedforward from 2e2f184

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 092a67d into autowarefoundation:main Dec 26, 2023
40 of 43 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-lane-change-states branch December 26, 2023 09:05
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…n#5950)

* refactor(lane_change): use new interface for state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix some state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix scenario failed

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix ablc not transitioning to success

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…n#5950)

* refactor(lane_change): use new interface for state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix some state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix scenario failed

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix ablc not transitioning to success

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…n#5950)

* refactor(lane_change): use new interface for state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix some state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix scenario failed

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix ablc not transitioning to success

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…n#5950)

* refactor(lane_change): use new interface for state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix some state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix scenario failed

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix ablc not transitioning to success

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…n#5950)

* refactor(lane_change): use new interface for state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix some state

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix scenario failed

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix ablc not transitioning to success

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants