Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): add static collision check end polygon marker #5955

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 25, 2023

Description

static collision check end pose and polygon is visualized as red arrow and polygon.

collision_check_distance_from_end: -10.0

image

pull_out_back-2023-12-25_16.42.03.mp4

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2023
@kosuke55 kosuke55 changed the title feat(start_planner): add static collision check end polygon feat(start_planner): add static collision check end polygon marker Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (83d316c) 15.28% compared to head (9494f9e) 15.27%.
Report is 2 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5955      +/-   ##
==========================================
- Coverage   15.28%   15.27%   -0.01%     
==========================================
  Files        1750     1750              
  Lines      120435   120454      +19     
  Branches    36731    36731              
==========================================
  Hits        18405    18405              
- Misses      81378    81397      +19     
  Partials    20652    20652              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.28% <ø> (ø) Carriedforward from 83d316c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 4016c05 into main Dec 26, 2023
38 of 42 checks passed
@kosuke55 kosuke55 deleted the feat/pull_out_collision_check_marker branch December 26, 2023 17:01
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…utowarefoundation#5955)

feat(start_planner): add static collision check end polygon

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5955)

feat(start_planner): add static collision check end polygon

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5955)

feat(start_planner): add static collision check end polygon

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#5955)

feat(start_planner): add static collision check end polygon

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants