-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(motion_velocity_smoother): front wheel steer rate calculation #5965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
autowarefoundation#5964 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5965 +/- ##
==========================================
- Coverage 15.25% 15.24% -0.01%
==========================================
Files 1750 1750
Lines 120562 120635 +73
Branches 36735 36787 +52
==========================================
Hits 18392 18392
- Misses 81543 81615 +72
- Partials 20627 20628 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…towarefoundation#5965) autowarefoundation#5964 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
…towarefoundation#5965) autowarefoundation#5964 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
…towarefoundation#5965) autowarefoundation#5964 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
…towarefoundation#5965) autowarefoundation#5964 Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
see #5964
Description
Tests performed
Not applicable.
Effects on system behavior
Before PR,
front_wheel_angle_rad
values were shifted by 1 point forward. Consequently, Autoware may now turn slightly later than before.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.