Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): front wheel steer rate calculation #5965

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

VRichardJP
Copy link
Contributor

see #5964

Description

Tests performed

Not applicable.

Effects on system behavior

Before PR, front_wheel_angle_rad values were shifted by 1 point forward. Consequently, Autoware may now turn slightly later than before.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 26, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

autowarefoundation#5964

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e4e3b61) 15.25% compared to head (3a82e0f) 15.24%.
Report is 5 commits behind head on main.

Files Patch % Lines
...n_velocity_smoother/src/smoother/smoother_base.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5965      +/-   ##
==========================================
- Coverage   15.25%   15.24%   -0.01%     
==========================================
  Files        1750     1750              
  Lines      120562   120635      +73     
  Branches    36735    36787      +52     
==========================================
  Hits        18392    18392              
- Misses      81543    81615      +72     
- Partials    20627    20628       +1     
Flag Coverage Δ *Carryforward flag
differential 14.71% <50.00%> (?)
total 15.25% <ø> (-0.01%) ⬇️ Carriedforward from e4e3b61

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit e4e129e into autowarefoundation:main Dec 28, 2023
30 of 33 checks passed
@VRichardJP VRichardJP deleted the patch-6 branch December 28, 2023 02:38
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants