Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(behavior_velocity): occlusion spot #601

Merged
merged 6 commits into from
Mar 29, 2022
Merged

refactor(behavior_velocity): occlusion spot #601

merged 6 commits into from
Mar 29, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 29, 2022 •
edited
Loading

Description

#258
refactor occlusion spot

  • make sure behavior is the same as before

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
refactor(behavior_velocity): refactor codes
c4ee2eb 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
refactor(behavior_velocity): fix typo
fa71d7e 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
refactor(behavior_velocity): refactor debuggings
b985d0d 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
refactor(behavior_velocity): unite to generate
59e3180 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
refactor(behavior_velocity): apply clang tidy
0ecb73c 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 requested a review from 0x126 March 29, 2022 03:28
@taikitanaka3 taikitanaka3 changed the title Refactor behavior velocity occlusion spot refactor(behavior_velocity): occlusion spot Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #601 (60a17c9) into main (21a3037) will decrease coverage by 5.03%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main    #601      +/-   ##
=========================================
- Coverage   10.85%   5.81%   -5.04%     
=========================================
  Files         708      68     -640     
  Lines       50173    5053   -45120     
  Branches     6579     545    -6034     
=========================================
- Hits         5445     294    -5151     
+ Misses      40321    4596   -35725     
+ Partials     4407     163    -4244
Impacted Files Coverage Δ
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 25.00% <ø> (ø)
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 9.67% <0.00%> (+0.05%) ⬆️
..._module/occlusion_spot/risk_predictive_braking.cpp 52.00% <ø> (+2.94%) ⬆️
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp
...l/trajectory_follower/test/test_lowpass_filter.cpp
...bject_tracker/tracker/model/pedestrian_tracker.hpp
control/trajectory_follower/test/test_pid.cpp
common/motion_testing/test/constant_trajectory.cpp
... and 636 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a3037...60a17c9. Read the comment docs.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review March 29, 2022 04:15
@taikitanaka3
chore(behavior_velocity): retun to default settting
60a17c9 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
0x126
0x126 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit ca59048 into autowarefoundation:main Mar 29, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 30, 2022
Merged
@taikitanaka3 taikitanaka3 deleted the refactor-behavior-velocity-occlusion-spot branch March 30, 2022 05:14
taikitanaka3 added a commit to taikitanaka3/autoware.universe that referenced this pull request Apr 1, 2022
@taikitanaka3
refactor(behavior_velocity): occlusion spot (autowarefoundation#601)
621f01e 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 9, 2022
@taikitanaka3
refactor(behavior_velocity): occlusion spot (#601)
21cf926 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
@taikitanaka3
refactor(behavior_velocity): occlusion spot (#601)
9265717 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
@taikitanaka3
refactor(behavior_velocity): occlusion spot (#601)
6b7e1b2 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
@taikitanaka3 @TomohitoAndo
refactor(behavior_velocity): occlusion spot (autowarefoundation#601)
0a12989 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@taikitanaka3 @boyali
refactor(behavior_velocity): occlusion spot (tier4#601)
74f54f3 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
refactor(behavior_velocity): occlusion spot (tier4#601)
90ac4e9 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
refactor(behavior_velocity): occlusion spot (tier4#601)
23a8fd9 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@taikitanaka3 @boyali
refactor(behavior_velocity): occlusion spot (tier4#601)
552d6dd 
* refactor(behavior_velocity): refactor codes

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): refactor debuggings

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): unite to generate

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(behavior_velocity): apply clang tidy

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(behavior_velocity): retun to default settting

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jun 26, 2023
@satoshi-ota
feat(avoidance): ignore behind unavoidable objects (autowarefoundatio…
24b2706 
…n#4034) (autowarefoundation#601)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@kenji-miyake
ci(sync-files): sync .fdignore and .rgignore (#601)
5eabb75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@0x126 0x126 0x126 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taikitanaka3 @0x126 @yukkysaito