Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_metrics_rviz_plugin): fix metrics_name column #6568

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 7, 2024

Description

Fixed metrics_name column is reversed to "metrics_name" and its value.

before
image

after
image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Mar 7, 2024
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (59f7031) to head (1ca692c).
Report is 18 commits behind head on main.

Files Patch % Lines
...etrics_rviz_plugin/src/metrics_visualize_panel.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6568   +/-   ##
=======================================
  Coverage   14.78%   14.78%           
=======================================
  Files        1917     1917           
  Lines      132038   132029    -9     
  Branches    39228    39221    -7     
=======================================
  Hits        19523    19523           
+ Misses      90726    90717    -9     
  Partials    21789    21789           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 59f7031

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit 3381296 into autowarefoundation:main Mar 7, 2024
36 of 37 checks passed
@kosuke55 kosuke55 deleted the fix/metrics_viz branch March 7, 2024 14:15
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…dation#6568)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants