-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_metrics_rviz_plugin): fix metrics_name column #6568
Conversation
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6568 +/- ##
=======================================
Coverage 14.78% 14.78%
=======================================
Files 1917 1917
Lines 132038 132029 -9
Branches 39228 39221 -7
=======================================
Hits 19523 19523
+ Misses 90726 90717 -9
Partials 21789 21789
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…dation#6568) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…dation#6568) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
Fixed metrics_name column is reversed to "metrics_name" and its value.
before
after
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.