Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_metrics_rviz_plugin): switch visualization target topic #6571

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 7, 2024

Description

switch visualization target topic

  • "/diagnostic/planning_evaluator/metrics"
  • "/diagnostic/perception_online_evaluator/metrics"
metrics_viz-2024-03-08_02.05.25.mp4

Tests performed

psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Mar 7, 2024
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 14.79%. Comparing base (edc6ef0) to head (005a092).
Report is 3 commits behind head on main.

Files Patch % Lines
...etrics_rviz_plugin/src/metrics_visualize_panel.cpp 0.00% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6571      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132157   132154       -3     
  Branches    39272    39258      -14     
==========================================
- Hits        19553    19552       -1     
- Misses      90783    90784       +1     
+ Partials    21821    21818       -3     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from edc6ef0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/metrics_viz_for_each_topic branch from 36c82f6 to a7af063 Compare March 8, 2024 02:55
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/metrics_viz_for_each_topic branch from a7af063 to 005a092 Compare March 8, 2024 02:56
@kosuke55 kosuke55 merged commit aa84a5e into autowarefoundation:main Mar 8, 2024
23 of 25 checks passed
@kosuke55 kosuke55 deleted the feat/metrics_viz_for_each_topic branch March 8, 2024 04:17
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…6571)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…utowarefoundation#6571)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants