Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): calculate path lanelets that we can miss during a lane change #6600

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Mar 12, 2024

Description

path_lanelets are not considered for overlaps in the out_of_lane. They are currently calculated as all the lanelets crossed by the ego path linestring.
In some lane change edge cases, the ego path linestring does not cross a lanelet but the ego footprint will overlap the lanelet, possibly causing the out_of_lane module to detect a collision and cause a stop.

With this PR, a function to add the missing lane change lanelets is added.

Illustration of the issue

In the following picture, the lane changing path (green) overlaps the 4 lanelets, but the current path_lanelets only includes 3 lanelets (in blue). With this PR, all 4 lanelets are correctly found.

image image

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=f10ea9b0-4317-557e-99d6-c0648cc11dcd&project_id=prd_jt&table_config=date

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 12, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (b7fdccc) to head (905f170).
Report is 2 commits behind head on main.

Files Patch % Lines
...city_out_of_lane_module/src/lanelets_selection.cpp 45.83% 0 Missing and 13 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6600   +/-   ##
=======================================
  Coverage   14.79%   14.80%           
=======================================
  Files        1915     1915           
  Lines      132352   132375   +23     
  Branches    39333    39346   +13     
=======================================
+ Hits        19580    19593   +13     
+ Misses      90939    90938    -1     
- Partials    21833    21844   +11     
Flag Coverage Δ *Carryforward flag
differential 21.90% <45.83%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from b7fdccc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 1d721dc into autowarefoundation:main Mar 26, 2024
33 checks passed
@maxime-clem maxime-clem deleted the fix/out_of_lane-missing-lane-change-path_lanelets branch March 26, 2024 08:01
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 26, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 26, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 27, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 27, 2024
…ane change (#1210)

fix(out_of_lane): calculate path lanelets that we can miss during a lane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Apr 8, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants