-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(out_of_lane): calculate path lanelets that we can miss during a lane change #6600
Merged
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-missing-lane-change-path_lanelets
Mar 26, 2024
Merged
fix(out_of_lane): calculate path lanelets that we can miss during a lane change #6600
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-missing-lane-change-path_lanelets
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
March 12, 2024 08:46
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Mar 12, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Mar 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6600 +/- ##
=======================================
Coverage 14.79% 14.80%
=======================================
Files 1915 1915
Lines 132352 132375 +23
Branches 39333 39346 +13
=======================================
+ Hits 19580 19593 +13
+ Misses 90939 90938 -1
- Partials 21833 21844 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Mar 26, 2024
maxime-clem
deleted the
fix/out_of_lane-missing-lane-change-path_lanelets
branch
March 26, 2024 08:01
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 26, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 26, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This was referenced Mar 26, 2024
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 27, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 27, 2024
…ane change (#1210) fix(out_of_lane): calculate path lanelets that we can miss during a lane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 1, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Apr 8, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ane change (autowarefoundation#6600) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
path_lanelets
are not considered for overlaps in theout_of_lane
. They are currently calculated as all the lanelets crossed by the ego path linestring.In some lane change edge cases, the ego path linestring does not cross a lanelet but the ego footprint will overlap the lanelet, possibly causing the
out_of_lane
module to detect a collision and cause a stop.With this PR, a function to add the missing lane change lanelets is added.
Illustration of the issue
In the following picture, the lane changing path (green) overlaps the 4 lanelets, but the current
path_lanelets
only includes 3 lanelets (in blue). With this PR, all 4 lanelets are correctly found.Tests performed
Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=f10ea9b0-4317-557e-99d6-c0648cc11dcd&project_id=prd_jt&table_config=date
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.