Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(object_range_splitter): rework parameters #6705

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Mar 28, 2024

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Build and launched ROS Node locally.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt self-assigned this Mar 28, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 28, 2024
.
Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oguzkaganozt and others added 2 commits March 28, 2024 13:12
.
Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) March 28, 2024 10:21
@oguzkaganozt oguzkaganozt added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 3, 2024
@oguzkaganozt oguzkaganozt merged commit d4ec8d3 into main Apr 3, 2024
34 checks passed
@oguzkaganozt oguzkaganozt deleted the refactor/object_range_splitter branch April 3, 2024 11:14
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Apr 5, 2024
…n#6705)

* rework parameters

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
esteve pushed a commit that referenced this pull request Apr 9, 2024
* rework parameters

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…n#6705)

* rework parameters

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* .

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants