fix(route_handler): exception in route_handler caused by int overflow #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebekx
requested review from
rej55,
kosuke55,
soblin,
takayuki5168 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
sebekx
changed the title
sebekx
changed the title
Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
sebekx
force-pushed
the
fix-route-handler
branch
from
067890d
to
6617ec1
Compare
sebekx
changed the title
sebekx
changed the title
|
It looks like we need to care invalid narrowing conversion throughout the codebase for better quality. |
shmpwk
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6755 +/- ##
=======================================
Coverage 14.93% 14.93%
=======================================
Files 1944 1944
Lines 134061 134061
Branches 39891 39891
=======================================
Hits 20025 20025
Misses 91735 91735
Partials 22301 22301
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 8, 2024
…autowarefoundation#6755) Remove cast to int which might cause overflow Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
esteve
pushed a commit
that referenced
this pull request
Apr 9, 2024
…#6755) Remove cast to int which might cause overflow Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…autowarefoundation#6755) Remove cast to int which might cause overflow Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl> Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed cast to int which cause overflow and exception when lanelet id is greater than int. verified that lanelet.Id is type int64
Tests performed
before, exception was thrown because could not find element with negative id :
after there is no exception
Effects on system behavior
Fix exception in case when lanelet contains larger ids (int could not handle)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.