-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(multi_object_tracker): change node and glog implementation #6780
Merged
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:chore/mot-change-glog-impl
Apr 10, 2024
Merged
chore(multi_object_tracker): change node and glog implementation #6780
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:chore/mot-change-glog-impl
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
github-actions
bot
added
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
Apr 9, 2024
technolojin
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Apr 9, 2024
kminoda
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
YoshiRi
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
esteve
pushed a commit
that referenced
this pull request
Apr 12, 2024
* chore: change node and glog impl Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
May 24, 2024
…ion (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Merged
4 tasks
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
May 24, 2024
…ion (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
May 24, 2024
…ion (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
added a commit
that referenced
this pull request
May 27, 2024
…le node components (#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin
added a commit
to technolojin/autoware.universe
that referenced
this pull request
May 31, 2024
…ion (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#6780) * chore: change node and glog impl Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…le node components (autowarefoundation#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…le node components (autowarefoundation#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…le node components (#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligning 'glog' implementation: Explicitly define ros node.
Reference: PR https://github.com/autowarefoundation/autoware.universe/pull/6767/files
Tests performed
find pid by
ps -efH|grep multi_object_tracker
manually terminate
kill -15 <pid>
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.