Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(multi_object_tracker): change node and glog implementation #6780

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Apr 9, 2024

Description

Aligning 'glog' implementation: Explicitly define ros node.
Reference: PR https://github.com/autowarefoundation/autoware.universe/pull/6767/files

Tests performed

find pid by ps -efH|grep multi_object_tracker
manually terminate kill -15 <pid>

[multi_object_tracker-60] [INFO] [1712655999.744011105] [rclcpp]: signal_handler(signum=15)
[multi_object_tracker-60] *** Aborted at 1712655999 (unix time) try "date -d @1712655999" if you are using GNU date ***
[multi_object_tracker-60] PC: @                0x0 (unknown)
[multi_object_tracker-60] *** SIGTERM (@0x3e8000d177e) received by PID 910105 (TID 0x7f653cf17640) from PID 857982; stack trace: ***
[multi_object_tracker-60]     @     0x7f653e1c9046 (unknown)
[multi_object_tracker-60]     @     0x7f653e5c6ded rclcpp::SignalHandler::signal_handler()
[multi_object_tracker-60]     @     0x7f653dd7a520 (unknown)
[multi_object_tracker-60]     @     0x7f653ddc9117 (unknown)
[multi_object_tracker-60]     @     0x7f653ddd4c78 (unknown)
[multi_object_tracker-60]     @     0x7f653e5c6b92 rclcpp::SignalHandler::wait_for_signal()
[multi_object_tracker-60]     @     0x7f653e5c7a0e rclcpp::SignalHandler::deferred_signal_handler()
[multi_object_tracker-60]     @     0x7f653e05d253 (unknown)
[multi_object_tracker-60]     @     0x7f653ddccac3 (unknown)
[multi_object_tracker-60]     @     0x7f653de5e850 (unknown)
[multi_object_tracker-60]     @                0x0 (unknown)
[ERROR] [multi_object_tracker-60]: process has died [pid 910105, exit code -15, cmd '/home/taekjinlee/workspace/dev-xx1/autoware/install/multi_object_tracker/lib/multi_object_tracker/multi_object_tracker --ros-args -r __node:=multi_object_tracker -r __ns:=/perception/object_recognition/tracking -p use_sim_time:=True -p wheel_radius:=0.31 -p wheel_width:=0.18 -p wheel_base:=2.75 -p wheel_tread:=1.485 -p front_overhang:=0.8 -p rear_overhang:=0.85 -p left_overhang:=0.105 -p right_overhang:=0.105 -p vehicle_height:=2.5 -p max_steer_angle:=0.55 --params-file /home/taekjinlee/workspace/dev-xx1/autoware/install/autoware_launch/share/autoware_launch/config/perception/object_recognition/tracking/multi_object_tracker/multi_object_tracker_node.param.yaml --params-file /home/taekjinlee/workspace/dev-xx1/autoware/install/autoware_launch/share/autoware_launch/config/perception/object_recognition/tracking/multi_object_tracker/data_association_matrix.param.yaml -r input:=/perception/object_recognition/detection/objects -r output:=/perception/object_recognition/tracking/near_objects'].

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Apr 9, 2024
@technolojin technolojin self-assigned this Apr 9, 2024
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 9, 2024
@technolojin technolojin marked this pull request as ready for review April 9, 2024 23:58
@technolojin technolojin requested a review from kminoda April 9, 2024 23:58
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@technolojin technolojin enabled auto-merge (squash) April 10, 2024 00:18
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 81c432e into autowarefoundation:main Apr 10, 2024
27 of 28 checks passed
esteve pushed a commit that referenced this pull request Apr 12, 2024
* chore: change node and glog impl

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request May 24, 2024
…ion (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request May 24, 2024
…ion (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request May 24, 2024
…ion (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin added a commit that referenced this pull request May 27, 2024
…le node components (#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request May 31, 2024
…ion (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…owarefoundation#6780)

* chore: change node and glog impl

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…le node components (autowarefoundation#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…le node components (autowarefoundation#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…le node components (#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the chore/mot-change-glog-impl branch July 26, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants