revert: "feat(logger_level_configure): make it possible to change level of container logger (#6823)" #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el of container logger (autowarefoundation#6823)" This reverts commit 51b5f83.
satoshi-ota
requested review from
isamu-takagi,
kosuke55,
soblin,
mitsudome-r,
TakaHoribe,
takayuki5168,
rej55,
kyoichi-sugahara,
mkuri,
shmpwk,
taikitanaka3,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
component:planning
TakaHoribe
approved these changes
Apr 18, 2024
satoshi-ota
added
the
tag:run-build-and-test-differential
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…el of container logger (autowarefoundation#6823)" (autowarefoundation#6842) This reverts commit 51b5f83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found we don't have to create and load LoggerLevelConfigureNode to container. Sorry for confusion.
This reverts commit 51b5f83.
Tests performed
Psim.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.