Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(clang-tidy-differential): split it out of build-and-test-differential #7331

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 6, 2024

Description

Splitting this out since it is not a required CI and we are short on runner compute.

Also added a new label: tag:run-clang-tidy-differential

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx requested a review from mitsudome-r June 6, 2024 15:34
@xmfcx xmfcx added tag:run-clang-tidy-differential tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 6, 2024
@xmfcx xmfcx self-assigned this Jun 6, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Jun 6, 2024

Also even if build-and-test-differential is successful, because clang-tidy-differential fails, it makes all red.

image

Once this is merged, it won't be like that anymore.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 6, 2024
@xmfcx xmfcx requested a review from kminoda June 6, 2024 15:53
@xmfcx xmfcx enabled auto-merge (squash) June 6, 2024 15:59
@xmfcx xmfcx merged commit 4aeb69f into main Jun 7, 2024
54 of 56 checks passed
@xmfcx xmfcx deleted the ci/split-clang-tidy branch June 7, 2024 08:08
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ial (#7331)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants